fix: Warnings raised by underlying seaborn and numpy libraries by jxnior01 · Pull Request #425 · Safe-DS/Library

jxnior01 · 2023-07-06T13:26:49Z

Closes #357

Summary of Changes

Python's warnings module now ignores warnings caused by underlying seaborn and numpy libraries.

…h in code and test. `addopts = -p no:warnings` was used to get warning message

github-actions · 2023-07-06T13:28:29Z

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	3	0	0	0.86s
✅ PYTHON	mypy	3		0	1.92s
✅ PYTHON	ruff	3	0	0	0.09s
✅ REPOSITORY	git_diff	yes		no	0.06s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

codecov · 2023-07-06T13:29:07Z

Codecov Report

Merging #425 (9a0186e) into main (ada934c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #425   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         2676      2683    +7     
=========================================
+ Hits          2676      2683    +7

Impacted Files	Coverage Δ
src/safeds/data/tabular/containers/_table.py	`100.00% <100.00%> (ø)`

src/safeds/data/tabular/containers/_table.py

zzril · 2023-07-06T14:25:00Z

Looks good to me.

Generally, it would be good to understand what originally caused the warnings, though.

Maybe someone with a better knowledge of numpy and matplotlib should have a look at this and make sure we're not missing a better way to implement the parts that raised the warnings?
@lars-reimann @Marsmaennchen221

jxnior01 · 2023-07-06T15:02:15Z

Looks good to me, aside from the redundancy.

Generally, it would be good to understand what originally caused the warnings, though.

I think the warning message is raised by the sns.heatmap() function from the seaborn library. It indicates that when it attempts to set identical low and high values for the x-axis (xlims) or y-axis (ylims) limits, it can result in a singular transformation. This is why seaborn automatically expands the limits to avoid this issue.

Marsmaennchen221 · 2023-07-06T21:28:01Z

As far as I understand the warning in Table.plot_correlation_heatmap is only raised if you use an empty table. Maybe it would be better to catch the warning only if the user tries to use this function on an empty table and raise a new warning that informs the user that a correlation heatmap on an empty table will show nothing.

src/safeds/data/tabular/containers/_table.py

Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>

patrikguempel

Reviewer cancelled review.

…d-numpy-libraries

tests/safeds/data/tabular/containers/_table/test_plot_correlation_heatmap.py

…ion_heatmap.py Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>

…d-numpy-libraries

## [0.15.0](v0.14.0...v0.15.0) (2023-07-13) ### Features * Add copy method for tables ([#405](#405)) ([72e87f0](72e87f0)), closes [#275](#275) * add gaussian noise to image ([#430](#430)) ([925a505](925a505)), closes [#381](#381) * add schema conversions when adding new rows to a table and schema conversion when creating a new table ([#432](#432)) ([6e9ff69](6e9ff69)), closes [#404](#404) [#322](#322) [#127](#127) [#322](#322) [#127](#127) * add test for empty tables for the method `Table.sort_rows` ([#431](#431)) ([f94b768](f94b768)), closes [#402](#402) * added color adjustment feature ([#409](#409)) ([2cbee36](2cbee36)), closes [#380](#380) * added test_repr table tests ([#410](#410)) ([cb77790](cb77790)), closes [#349](#349) * discretize table ([#327](#327)) ([5e3da8d](5e3da8d)), closes [#143](#143) * Improve error handling of TaggedTable ([#450](#450)) ([c5da544](c5da544)), closes [#150](#150) * Maintain tagging in methods inherited from `Table` class ([#332](#332)) ([bc73a6c](bc73a6c)), closes [#58](#58) * new error class `OutOfBoundsError` ([#438](#438)) ([1f37e4a](1f37e4a)), closes [#262](#262) * rename several `Table` methods for consistency ([#445](#445)) ([9954986](9954986)), closes [#439](#439) * suggest similar columns if column gets accessed that doesnt exist ([#385](#385)) ([6a097a4](6a097a4)), closes [#203](#203) ### Bug Fixes * added the missing ids in parameterized tests ([#412](#412)) ([dab6419](dab6419)), closes [#362](#362) * don't warn if `Imputer` transforms column without missing values ([#448](#448)) ([f0cb6a5](f0cb6a5)) * Warnings raised by underlying seaborn and numpy libraries ([#425](#425)) ([c4143af](c4143af)), closes [#357](#357)

lars-reimann · 2023-07-13T22:40:55Z

🎉 This PR is included in version 0.15.0 🎉

The release is available on:

v0.15.0
GitHub release

Your semantic-release bot 📦🚀

warnings caused by underlying seaborn and numpy libraries ignored bot…

e007747

…h in code and test. `addopts = -p no:warnings` was used to get warning message

jxnior01 requested a review from a team as a code owner July 6, 2023 13:26

jxnior01 linked an issue Jul 6, 2023 that may be closed by this pull request

Warnings raised by underlying seaborn and numpy libraries #357

Closed

style: apply automated linter fixes

9ef3b67

zzril reviewed Jul 6, 2023

View reviewed changes

src/safeds/data/tabular/containers/_table.py Outdated Show resolved Hide resolved

used regex to ignore warning message

18e1c10

Marsmaennchen221 reviewed Jul 6, 2023

View reviewed changes

src/safeds/data/tabular/containers/_table.py Outdated Show resolved Hide resolved

zzril mentioned this pull request Jul 7, 2023

test_discretizer.py raises warnings #434

Open

use strings to plot histograms

fb6d5b4

Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>

patrikguempel approved these changes Jul 7, 2023

View reviewed changes

patrikguempel previously requested changes Jul 7, 2023

View reviewed changes

jxnior01 and others added 4 commits July 7, 2023 16:15

empty table warning msg thrown, seaborn and numpy warnings ignored

1e01fc3

added stacklevel

c8096a8

style: apply automated linter fixes

34ca1b8

style: apply automated linter fixes

bb26adb

Merge branch 'main' into 357-warnings-raised-by-underlying-seaborn-an…

cb12545

…d-numpy-libraries

Marsmaennchen221 requested changes Jul 11, 2023

View reviewed changes

tests/safeds/data/tabular/containers/_table/test_plot_correlation_heatmap.py Show resolved Hide resolved

removed outdated comparison method

d1b5594

Marsmaennchen221 requested changes Jul 13, 2023

View reviewed changes

tests/safeds/data/tabular/containers/_table/test_plot_correlation_heatmap.py Outdated Show resolved Hide resolved

jxnior01 and others added 3 commits July 13, 2023 19:33

Update tests/safeds/data/tabular/containers/_table/test_plot_correlat…

22d8a8d

…ion_heatmap.py Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>

style: apply automated linter fixes

91ecc10

style: apply automated linter fixes

46dd2c6

zzril requested a review from Marsmaennchen221 July 13, 2023 17:49

Merge branch 'main' into 357-warnings-raised-by-underlying-seaborn-an…

040eef7

…d-numpy-libraries

Marsmaennchen221 approved these changes Jul 13, 2023

View reviewed changes

Merge branch 'main' into 357-warnings-raised-by-underlying-seaborn-an…

04e6fc5

…d-numpy-libraries

Marsmaennchen221 enabled auto-merge (squash) July 13, 2023 19:06

Merge branch 'main' into 357-warnings-raised-by-underlying-seaborn-an…

9a0186e

…d-numpy-libraries

Marsmaennchen221 merged commit c4143af into main Jul 13, 2023

Marsmaennchen221 deleted the 357-warnings-raised-by-underlying-seaborn-and-numpy-libraries branch July 13, 2023 19:19

lars-reimann added the released Included in a release label Jul 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Warnings raised by underlying seaborn and numpy libraries #425

fix: Warnings raised by underlying seaborn and numpy libraries #425
Marsmaennchen221 merged 16 commits intomainfrom
357-warnings-raised-by-underlying-seaborn-and-numpy-libraries

jxnior01 commented Jul 6, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jul 6, 2023 •

edited

Loading

Uh oh!

codecov bot commented Jul 6, 2023 •

edited

Loading

Uh oh!

Uh oh!

zzril commented Jul 6, 2023 •

edited

Loading

Uh oh!

jxnior01 commented Jul 6, 2023

Uh oh!

Marsmaennchen221 commented Jul 6, 2023 •

edited

Loading

Uh oh!

Uh oh!

patrikguempel left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

lars-reimann commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

jxnior01 commented Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Uh oh!

github-actions bot commented Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦙 MegaLinter status: ✅ SUCCESS

Uh oh!

codecov bot commented Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

zzril commented Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jxnior01 commented Jul 6, 2023

Uh oh!

Marsmaennchen221 commented Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

patrikguempel left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lars-reimann commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jxnior01 commented Jul 6, 2023 •

edited

Loading

github-actions bot commented Jul 6, 2023 •

edited

Loading

codecov bot commented Jul 6, 2023 •

edited

Loading

zzril commented Jul 6, 2023 •

edited

Loading

Marsmaennchen221 commented Jul 6, 2023 •

edited

Loading

patrikguempel left a comment •

edited

Loading