Skip to content

Remove unused convention plugin#3195

Merged
tonidero merged 3 commits into
mainfrom
remove-unused-convention-plugin
Mar 11, 2026
Merged

Remove unused convention plugin#3195
tonidero merged 3 commits into
mainfrom
remove-unused-convention-plugin

Conversation

@tonidero

@tonidero tonidero commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Description

Currently we don't need the Android library convention plugin since we only have public libraries that use a different convention plugin. We remove it for now, we can always add it back later if needed.

Based on #3194


Note

Low Risk
Low risk: this removes an unused Gradle convention plugin and its version-catalog alias, affecting only build configuration and only if any module still referenced the removed plugin ID.

Overview
Removes the revenuecat-android-library Gradle convention plugin from build logic by dropping its registration in build-logic/convention/build.gradle.kts and deleting AndroidLibraryConventionPlugin.

Cleans up the version catalog by removing the revenuecat-android-library plugin alias from gradle/libs.versions.toml.

Written by Cursor Bugbot for commit 380a00c. This will update automatically on new commits. Configure here.

AlexanderTalledo and others added 2 commits March 9, 2026 10:25
<!-- Thank you for contributing to Purchases! Before pressing the
"Create Pull Request" button, please provide the following: -->

### Checklist
- [x] If applicable, unit tests
- [x] If applicable, create follow-up issues for `purchases-ios` and
hybrids

### Motivation
<!-- Why is this change required? What problem does it solve? -->
While developers' priority is always the end-user, improving the
development experience (DX) and making the daily workflow more
comfortable for developers is equally vital. By integrating convention
plugins into Version Catalogs we do unlock a lot of benefits for
development with a very few small changes:
- **Standardization**: If we already add third party's plugins via
aliases, why should we add our plugins in a different way?
- **Single source of truth**: `libs.versions.toml` is the only place to
go.
- **Less error prone**: Avoid failure builds because of a typo or
misscopying the ID from somewhere else. This also safe us some time.
- **IDE capabilites**: Enables those helpfull features that make our
life easier.
    - Code auto-completion
    - Refactoring/renaming
    - Error highlighting
    - `ctrl/cmd + click` for jumping to definition or finding usages
<!-- Please link to issues following this format: Resolves #999999 -->

**Note:** I did not create any associated issue because I did not find
any category that matches the purpose of this PR. If this is mandatory,
please do let me know and point to under what category should be
created.

### Description
Integrate convention plugins into Version Catalogs to enable typesafe
alias accessors for locally registered custom convention plugins.
#### Changes
- Declare gradle convention plugins registered in
`build-logic/convention/build.gradle.kts` on
`gradle/libs.versions.toml`.
- Replace hardcoded convention plugins IDs across all modules by the
equivalent typesafe alias accessors.
    - Before:  `id("revenuecat-android-application")`
    - After: `alias(libs.plugins.revenuecat.android.application)`
#### Testing
- Verified that all modules successfully build after switching from
hardcoded IDs to aliases.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Touches Gradle configuration across multiple modules by changing how
core convention plugins are applied, so mistakes would surface as
build/IDE resolution failures. No runtime or library logic changes.
> 
> **Overview**
> Standardizes application of internal RevenueCat convention plugins by
moving their IDs into `gradle/libs.versions.toml` and using
`alias(libs.plugins...)` accessors instead of hardcoded
`id("revenuecat-...")`.
> 
> Updates the affected app and library modules (`purchases`, `ui/*`,
`feature/*`, `examples/*`, `integration-tests`, `api-tester`) to use the
new catalog aliases for the same convention plugins.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
7b1fe62. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@tonidero tonidero requested a review from a team as a code owner March 9, 2026 09:32
@codecov

codecov Bot commented Mar 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.32%. Comparing base (aa62672) to head (380a00c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3195   +/-   ##
=======================================
  Coverage   79.32%   79.32%           
=======================================
  Files         351      351           
  Lines       14164    14164           
  Branches     1933     1933           
=======================================
  Hits        11235    11235           
  Misses       2126     2126           
  Partials      803      803           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from external/AlexanderTalledo/integrate-convention-plugins-into-version-catalogs to main March 11, 2026 12:17
@tonidero tonidero enabled auto-merge March 11, 2026 12:18
@tonidero tonidero added this pull request to the merge queue Mar 11, 2026
Merged via the queue into main with commit 4c1280c Mar 11, 2026
29 checks passed
@tonidero tonidero deleted the remove-unused-convention-plugin branch March 11, 2026 12:55
This was referenced Mar 11, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Mar 12, 2026
**This is an automatic release.**

## RevenueCat SDK
### ✨ New Features
* [EXPERIMENTAL]: Beta Galaxy Store Support (#2903) via Will Taylor
(@fire-at-will)
### 🐞 Bugfixes
* Skip installation on GCP CLI in run-firebase-test (#3218) via Will
Taylor (@fire-at-will)
* Fix reduced timeouts being used for HTTP requests when a proxy URL is
configured (#3188) via Rick (@rickvdl)

## RevenueCatUI SDK
### 🐞 Bugfixes
* Fix missing ripple effect in View-based paywall wrappers (#3206) via
Toni Rico (@tonidero)
### Paywallv2
#### ✨ New Features
* Rules v0 Integration branch (#3117) via Cesar de la Vega (@vegaro)

### 🔄 Other Changes
* [Galaxy]: Add promotionEligibilities comment (#3214) via Will Taylor
(@fire-at-will)
* [EXTERNAL] Migrate deprecated buildDir to layout API (#3202)
contributed by @AlexanderTalledo (#3212) via Toni Rico (@tonidero)
* Remove automatic Claude code review workflow (#3211) via Cesar de la
Vega (@vegaro)
* Remove unused convention plugin (#3195) via Toni Rico (@tonidero)
* [EXTERNAL] Integrate convention plugins into Version Catalogs (#3181)
contributed by @AlexanderTalledo (#3194) via Toni Rico (@tonidero)
* [EXTERNAL] Migrate androidx cardview dependency to version catalogs
(#3192) contributed by @AlenxanderTalledo (#3193) via Toni Rico
(@tonidero)
* Improve AdMob adapter test coverage (#3204) via Pol Miro (@polmiro)
* Bump fastlane-plugin-revenuecat_internal from `f5c099b` to `e146447`
(#3197) via dependabot[bot] (@dependabot[bot])
* Fix integration tests (#3196) via Toni Rico (@tonidero)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk release bookkeeping: version strings and deployment paths are
updated from `9.24.0-SNAPSHOT` to `9.24.0`, plus changelog/docs refresh.
Main risk is accidental publishing/docs deployment to the wrong
versioned location.
> 
> **Overview**
> Cuts the `9.24.0` release by updating all version references from
`9.24.0-SNAPSHOT` to `9.24.0` (root `.version`, `gradle.properties`, and
`Config.frameworkVersion`), and aligning sample/test app version
catalogs to consume the released artifact.
> 
> Updates documentation publishing to point at the `9.24.0` directory
(CircleCI S3 sync and `docs/index.html` redirect) and refreshes
`CHANGELOG.latest.md`/`CHANGELOG.md` with the `9.24.0` release notes.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
8e6d567. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants