Skip to content

Migrate androidx cardview dependency to version catalogs#3192

Merged
tonidero merged 1 commit into
RevenueCat:external/AlexanderTalledo/migrate-androidx-cardview-to-version-catalogsfrom
AlexanderTalledo:migrate-androidx-cardview-to-version-catalogs
Mar 9, 2026
Merged

Migrate androidx cardview dependency to version catalogs#3192
tonidero merged 1 commit into
RevenueCat:external/AlexanderTalledo/migrate-androidx-cardview-to-version-catalogsfrom
AlexanderTalledo:migrate-androidx-cardview-to-version-catalogs

Conversation

@AlexanderTalledo

@AlexanderTalledo AlexanderTalledo commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-ios and hybrids

Motivation

Ensure architectural consistency and maintainability across the project.

Why is this change required?

Since the project is already using Versions Catalogs solutions to define and provide dependencies, this ensures we keep consistent across the project.

What problem does it solve?

  • Avoids the usage of hardcoded strings that becomes the project more error prone.
  • Keeps gradle/libs.versions.toml as a single source of truth.
  • Improves development experience by enabling IDE features: auto-completion, refactoring, error highlighting...

Description

Migrate androidx.cardview:cardview dependency to Version Catalogs.

Changes

  • Declare androidx.cardview:cardview dependency module and version in gradle/libs.versions.toml file.
  • Replace hardcoded dependency declaration by statically type parameter provided by Version Catalogs.

Testing

  • Verified that all modules successfully build after switching from hardcoded library dependency to statically typed parameter.

Note

Low Risk
Low risk build-configuration-only change that keeps the resolved CardView version the same, with minimal chance of dependency resolution issues.

Overview
Migrates the AdMob sample’s androidx.cardview:cardview dependency from an inline string to the version catalog by adding androidx-cardview (version 1.0.0) in gradle/libs.versions.toml and switching examples/admob-sample/build.gradle.kts to implementation(libs.androidx.cardview).

Written by Cursor Bugbot for commit 648548f. This will update automatically on new commits. Configure here.

@AlexanderTalledo AlexanderTalledo requested a review from a team as a code owner March 8, 2026 17:56
@tonidero tonidero changed the base branch from main to external/AlexanderTalledo/migrate-androidx-cardview-to-version-catalogs March 9, 2026 08:43

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! We will get this merged!

@tonidero tonidero merged commit ad213a7 into RevenueCat:external/AlexanderTalledo/migrate-androidx-cardview-to-version-catalogs Mar 9, 2026
1 check passed
github-merge-queue Bot pushed a commit that referenced this pull request Mar 11, 2026
…3192) contributed by @AlenxanderTalledo (#3193)

<!-- Thank you for contributing to Purchases! Before pressing the
"Create Pull Request" button, please provide the following: -->

### Checklist
- [x] If applicable, unit tests
- [x] If applicable, create follow-up issues for `purchases-ios` and
hybrids

### Motivation
Ensure architectural consistency and maintainability across the project.

#### Why is this change required?
Since the project is already using Versions Catalogs solutions to define
and provide dependencies, this ensures we keep consistent across the
project.

#### What problem does it solve?
- Avoids the usage of hardcoded strings that becomes the project more
error prone.
- Keeps `gradle/libs.versions.toml` as a single source of truth.
- Improves development experience by enabling IDE features:
auto-completion, refactoring, error highlighting...
### Description
Migrate `androidx.cardview:cardview` dependency to Version Catalogs.
<!-- Describe your changes in detail -->
#### Changes
- Declare `androidx.cardview:cardview` dependency module and version in
`gradle/libs.versions.toml` file.
- Replace hardcoded dependency declaration by statically type parameter
provided by Version Catalogs.

<!-- Please describe in detail how you tested your changes -->
#### Testing
- Verified that all modules successfully build after switching from
hardcoded library dependency to statically typed parameter.



<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk build configuration change: it only replaces a hardcoded
`androidx.cardview` dependency with a version-catalog entry, without
affecting runtime logic.
> 
> **Overview**
> Migrates the AdMob sample’s `androidx.cardview` dependency from a
hardcoded Maven string to the version catalog
(`libs.androidx.cardview`).
> 
> Adds the corresponding `androidx-cardview` library entry (and
`androidxCardView` version) to `gradle/libs.versions.toml` to keep
dependency versions centralized.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
ad213a7. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->



contributed by @AlexanderTalledo in #3192

Co-authored-by: Alexta <8045196+AlexanderTalledo@users.noreply.github.com>
This was referenced Mar 11, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Mar 12, 2026
**This is an automatic release.**

## RevenueCat SDK
### ✨ New Features
* [EXPERIMENTAL]: Beta Galaxy Store Support (#2903) via Will Taylor
(@fire-at-will)
### 🐞 Bugfixes
* Skip installation on GCP CLI in run-firebase-test (#3218) via Will
Taylor (@fire-at-will)
* Fix reduced timeouts being used for HTTP requests when a proxy URL is
configured (#3188) via Rick (@rickvdl)

## RevenueCatUI SDK
### 🐞 Bugfixes
* Fix missing ripple effect in View-based paywall wrappers (#3206) via
Toni Rico (@tonidero)
### Paywallv2
#### ✨ New Features
* Rules v0 Integration branch (#3117) via Cesar de la Vega (@vegaro)

### 🔄 Other Changes
* [Galaxy]: Add promotionEligibilities comment (#3214) via Will Taylor
(@fire-at-will)
* [EXTERNAL] Migrate deprecated buildDir to layout API (#3202)
contributed by @AlexanderTalledo (#3212) via Toni Rico (@tonidero)
* Remove automatic Claude code review workflow (#3211) via Cesar de la
Vega (@vegaro)
* Remove unused convention plugin (#3195) via Toni Rico (@tonidero)
* [EXTERNAL] Integrate convention plugins into Version Catalogs (#3181)
contributed by @AlexanderTalledo (#3194) via Toni Rico (@tonidero)
* [EXTERNAL] Migrate androidx cardview dependency to version catalogs
(#3192) contributed by @AlenxanderTalledo (#3193) via Toni Rico
(@tonidero)
* Improve AdMob adapter test coverage (#3204) via Pol Miro (@polmiro)
* Bump fastlane-plugin-revenuecat_internal from `f5c099b` to `e146447`
(#3197) via dependabot[bot] (@dependabot[bot])
* Fix integration tests (#3196) via Toni Rico (@tonidero)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk release bookkeeping: version strings and deployment paths are
updated from `9.24.0-SNAPSHOT` to `9.24.0`, plus changelog/docs refresh.
Main risk is accidental publishing/docs deployment to the wrong
versioned location.
> 
> **Overview**
> Cuts the `9.24.0` release by updating all version references from
`9.24.0-SNAPSHOT` to `9.24.0` (root `.version`, `gradle.properties`, and
`Config.frameworkVersion`), and aligning sample/test app version
catalogs to consume the released artifact.
> 
> Updates documentation publishing to point at the `9.24.0` directory
(CircleCI S3 sync and `docs/index.html` redirect) and refreshes
`CHANGELOG.latest.md`/`CHANGELOG.md` with the `9.24.0` release notes.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
8e6d567. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants