[EXTERNAL] Migrate androidx cardview dependency to version catalogs (#3192) contributed by @AlenxanderTalledo#3193
Merged
tonidero merged 1 commit intoMar 11, 2026
Conversation
<!-- Thank you for contributing to Purchases! Before pressing the "Create Pull Request" button, please provide the following: --> ### Checklist - [x] If applicable, unit tests - [x] If applicable, create follow-up issues for `purchases-ios` and hybrids ### Motivation Ensure architectural consistency and maintainability across the project. #### Why is this change required? Since the project is already using Versions Catalogs solutions to define and provide dependencies, this ensures we keep consistent across the project. #### What problem does it solve? - Avoids the usage of hardcoded strings that becomes the project more error prone. - Keeps `gradle/libs.versions.toml` as a single source of truth. - Improves development experience by enabling IDE features: auto-completion, refactoring, error highlighting... ### Description Migrate `androidx.cardview:cardview` dependency to Version Catalogs. <!-- Describe your changes in detail --> #### Changes - Declare `androidx.cardview:cardview` dependency module and version in `gradle/libs.versions.toml` file. - Replace hardcoded dependency declaration by statically type parameter provided by Version Catalogs. <!-- Please describe in detail how you tested your changes --> #### Testing - Verified that all modules successfully build after switching from hardcoded library dependency to statically typed parameter. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk build-configuration-only change that keeps the resolved CardView version the same, with minimal chance of dependency resolution issues. > > **Overview** > Migrates the AdMob sample’s `androidx.cardview:cardview` dependency from an inline string to the version catalog by adding `androidx-cardview` (version `1.0.0`) in `gradle/libs.versions.toml` and switching `examples/admob-sample/build.gradle.kts` to `implementation(libs.androidx.cardview)`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 648548f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3193 +/- ##
=======================================
Coverage 79.32% 79.32%
=======================================
Files 351 351
Lines 14164 14164
Branches 1933 1933
=======================================
Hits 11235 11235
Misses 2126 2126
Partials 803 803 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ajpallares
approved these changes
Mar 11, 2026
This was referenced Mar 11, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * [EXPERIMENTAL]: Beta Galaxy Store Support (#2903) via Will Taylor (@fire-at-will) ### 🐞 Bugfixes * Skip installation on GCP CLI in run-firebase-test (#3218) via Will Taylor (@fire-at-will) * Fix reduced timeouts being used for HTTP requests when a proxy URL is configured (#3188) via Rick (@rickvdl) ## RevenueCatUI SDK ### 🐞 Bugfixes * Fix missing ripple effect in View-based paywall wrappers (#3206) via Toni Rico (@tonidero) ### Paywallv2 #### ✨ New Features * Rules v0 Integration branch (#3117) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * [Galaxy]: Add promotionEligibilities comment (#3214) via Will Taylor (@fire-at-will) * [EXTERNAL] Migrate deprecated buildDir to layout API (#3202) contributed by @AlexanderTalledo (#3212) via Toni Rico (@tonidero) * Remove automatic Claude code review workflow (#3211) via Cesar de la Vega (@vegaro) * Remove unused convention plugin (#3195) via Toni Rico (@tonidero) * [EXTERNAL] Integrate convention plugins into Version Catalogs (#3181) contributed by @AlexanderTalledo (#3194) via Toni Rico (@tonidero) * [EXTERNAL] Migrate androidx cardview dependency to version catalogs (#3192) contributed by @AlenxanderTalledo (#3193) via Toni Rico (@tonidero) * Improve AdMob adapter test coverage (#3204) via Pol Miro (@polmiro) * Bump fastlane-plugin-revenuecat_internal from `f5c099b` to `e146447` (#3197) via dependabot[bot] (@dependabot[bot]) * Fix integration tests (#3196) via Toni Rico (@tonidero) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk release bookkeeping: version strings and deployment paths are updated from `9.24.0-SNAPSHOT` to `9.24.0`, plus changelog/docs refresh. Main risk is accidental publishing/docs deployment to the wrong versioned location. > > **Overview** > Cuts the `9.24.0` release by updating all version references from `9.24.0-SNAPSHOT` to `9.24.0` (root `.version`, `gradle.properties`, and `Config.frameworkVersion`), and aligning sample/test app version catalogs to consume the released artifact. > > Updates documentation publishing to point at the `9.24.0` directory (CircleCI S3 sync and `docs/index.html` redirect) and refreshes `CHANGELOG.latest.md`/`CHANGELOG.md` with the `9.24.0` release notes. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 8e6d567. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-iosand hybridsMotivation
Ensure architectural consistency and maintainability across the project.
Why is this change required?
Since the project is already using Versions Catalogs solutions to define and provide dependencies, this ensures we keep consistent across the project.
What problem does it solve?
gradle/libs.versions.tomlas a single source of truth.Description
Migrate
androidx.cardview:cardviewdependency to Version Catalogs.Changes
androidx.cardview:cardviewdependency module and version ingradle/libs.versions.tomlfile.Testing
Note
Low Risk
Low risk build configuration change: it only replaces a hardcoded
androidx.cardviewdependency with a version-catalog entry, without affecting runtime logic.Overview
Migrates the AdMob sample’s
androidx.cardviewdependency from a hardcoded Maven string to the version catalog (libs.androidx.cardview).Adds the corresponding
androidx-cardviewlibrary entry (andandroidxCardViewversion) togradle/libs.versions.tomlto keep dependency versions centralized.Written by Cursor Bugbot for commit ad213a7. This will update automatically on new commits. Configure here.
contributed by @AlexanderTalledo in #3192