Fix reduced timeouts being used for HTTP requests when a proxy URL is configured#3188
Merged
rickvdl merged 2 commits intoMar 9, 2026
Merged
Conversation
…RL is set When a proxy URL is configured, fallback URLs are disabled. However, the timeout manager still applied the aggressive 5s/2s timeouts meant for endpoints with fallback support. This caused proxy requests to time out with no fallback recovery path, making the proxy unusable for slow connections.
… + hasProxyURL Move the fallback availability check (supportsFallbackBaseURLs && no proxy) to the caller, simplifying the timeout manager interface.
dbf1455 to
cd352cd
Compare
tonidero
approved these changes
Mar 6, 2026
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the quick fix! 🙏
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3188 +/- ##
==========================================
- Coverage 79.32% 79.32% -0.01%
==========================================
Files 351 351
Lines 14131 14132 +1
Branches 1928 1928
==========================================
Hits 11210 11210
Misses 2121 2121
- Partials 800 801 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
tonidero
added a commit
that referenced
this pull request
Mar 9, 2026
### Description Fix for integration tests. One of them broke with the changes in #3188 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Test-only change that updates a mocked `AppConfig` to match a newer interface; no production logic is modified. > > **Overview** > Fixes broken Android integration tests by updating `PurchasesIntegrationTest`'s mocked `AppConfig` to provide `fallbackBaseURLs` (set to an empty list) when constructing the `HTTPClient`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 06e4f9f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This was referenced Mar 11, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * [EXPERIMENTAL]: Beta Galaxy Store Support (#2903) via Will Taylor (@fire-at-will) ### 🐞 Bugfixes * Skip installation on GCP CLI in run-firebase-test (#3218) via Will Taylor (@fire-at-will) * Fix reduced timeouts being used for HTTP requests when a proxy URL is configured (#3188) via Rick (@rickvdl) ## RevenueCatUI SDK ### 🐞 Bugfixes * Fix missing ripple effect in View-based paywall wrappers (#3206) via Toni Rico (@tonidero) ### Paywallv2 #### ✨ New Features * Rules v0 Integration branch (#3117) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * [Galaxy]: Add promotionEligibilities comment (#3214) via Will Taylor (@fire-at-will) * [EXTERNAL] Migrate deprecated buildDir to layout API (#3202) contributed by @AlexanderTalledo (#3212) via Toni Rico (@tonidero) * Remove automatic Claude code review workflow (#3211) via Cesar de la Vega (@vegaro) * Remove unused convention plugin (#3195) via Toni Rico (@tonidero) * [EXTERNAL] Integrate convention plugins into Version Catalogs (#3181) contributed by @AlexanderTalledo (#3194) via Toni Rico (@tonidero) * [EXTERNAL] Migrate androidx cardview dependency to version catalogs (#3192) contributed by @AlenxanderTalledo (#3193) via Toni Rico (@tonidero) * Improve AdMob adapter test coverage (#3204) via Pol Miro (@polmiro) * Bump fastlane-plugin-revenuecat_internal from `f5c099b` to `e146447` (#3197) via dependabot[bot] (@dependabot[bot]) * Fix integration tests (#3196) via Toni Rico (@tonidero) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk release bookkeeping: version strings and deployment paths are updated from `9.24.0-SNAPSHOT` to `9.24.0`, plus changelog/docs refresh. Main risk is accidental publishing/docs deployment to the wrong versioned location. > > **Overview** > Cuts the `9.24.0` release by updating all version references from `9.24.0-SNAPSHOT` to `9.24.0` (root `.version`, `gradle.properties`, and `Config.frameworkVersion`), and aligning sample/test app version catalogs to consume the released artifact. > > Updates documentation publishing to point at the `9.24.0` directory (CircleCI S3 sync and `docs/index.html` redirect) and refreshes `CHANGELOG.latest.md`/`CHANGELOG.md` with the `9.24.0` release notes. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 8e6d567. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppConfig.fallbackBaseURLsis empty). However, the timeout manager still applied the aggressive 5s/2s timeouts meant for endpoints with fallback support.hasProxyURLparameter toHTTPTimeoutManager.getTimeoutForRequest()so it uses the default timeout when a proxy is active.Related PR: RevenueCat/purchases-ios#6416
Test plan
getTimeoutForRequest returns DEFAULT_TIMEOUT_MS for fallback-supporting endpoint when proxy URL is setgetTimeoutForRequest returns DEFAULT_TIMEOUT_MS after timeout when proxy URL is set