Support for Billing Client 6#1209
Merged
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
- Coverage 85.83% 85.51% -0.33%
==========================================
Files 186 187 +1
Lines 6319 6358 +39
Branches 918 923 +5
==========================================
+ Hits 5424 5437 +13
- Misses 546 567 +21
- Partials 349 354 +5
☔ View full report in Codecov by Sentry. |
14619ac to
afb74ab
Compare
vegaro
reviewed
Aug 24, 2023
vegaro
reviewed
Aug 24, 2023
Closed
543856e to
3173653
Compare
NachoSoto
reviewed
Sep 21, 2023
tonidero
reviewed
Sep 22, 2023
vegaro
reviewed
Sep 25, 2023
vegaro
approved these changes
Sep 25, 2023
aboedo
reviewed
Sep 25, 2023
tonidero
reviewed
Sep 26, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Maybe we should remove the commented out code temporarily as Andy suggested.
3c6cef9 to
ca82851
Compare
Member
Author
This was referenced Sep 27, 2023
f4b99bd to
9e2f693
Compare
aboedo
reviewed
Sep 27, 2023
Comment on lines
+9
to
+12
| However, there is a behavior change in the "DEFERRED" replacement mode. Previously, a purchase would only occur after the | ||
| product change. In BC6, the new purchase occurs place immediately, while the product change becomes effective when the old | ||
| item expires. Until we can properly support this new behaviour, we have disabled the "DEFERRED" replacement mode and it | ||
| will be added back in a future release of the SDK. |
Member
There was a problem hiding this comment.
Let's make it the implications for a developer super explicit here: I might not know whether this affects me at all, and it most likely doesn't.
Maybe something like
If your app supports product changes using DEFERRED replacement mode (link to docs), then you can either stick with the previous major version until support for DEFERRED is re-introduced in this major version, or you can remove DEFERRED replacement options from your app.
If your app doesn't currently use DEFERRED replacement modes, then you should be safe to upgrade to this version without changes in behavior.
Member
There was a problem hiding this comment.
or maybe flipping the order of those since DEFERRED isn't very widely used
Member
|
looks good! Left one minor note, good to go otherwise |
Merged
MarkVillacampa
added a commit
that referenced
this pull request
Sep 28, 2023
### Breaking Changes * Support for Billing Client 6 (#1209) via Mark Villacampa (@MarkVillacampa) * Bump minimum sdk version to Android 4.4 (API level 19) (#1265) via Mark Villacampa (@MarkVillacampa) * in app messages support (#1290) via Andy Boedo (@aboedo) ### Bugfixes * Add `awaitRestore` to customEntitlementComputation library (#1275) via Toni Rico (@tonidero) ### Other Changes * Future-proof in-app message APIs in case new types are added (#1293) via Toni Rico (@tonidero) * `Code style`: enabled `ALLOW_TRAILING_COMMA` (#1280) via NachoSoto (@NachoSoto)
MarkVillacampa
added a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Oct 3, 2023
… to Billing Client 6 (#506) Refer to RevenueCat/purchases-android#1209 for more information
tonidero
pushed a commit
to RevenueCat/cordova-plugin-purchases
that referenced
this pull request
Oct 4, 2023
… to Billing Client 6 (#425) Refer to RevenueCat/purchases-android#1209 for more information
MarkVillacampa
added a commit
to RevenueCat/purchases-flutter
that referenced
this pull request
Oct 5, 2023
… to Billing Client 6 (#821) Refer to RevenueCat/purchases-android#1209 for more information
Jethro87
pushed a commit
to Jethro87/purchases-flutter
that referenced
this pull request
Jan 4, 2025
… to Billing Client 6 (RevenueCat#821) Refer to RevenueCat/purchases-android#1209 for more information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping Billing client to 6.0.0