Made some classes and functions internal#1289
Conversation
|
|
||
| // Public because it's been used in the hybrids | ||
| fun warnLog(message: String) { | ||
| internal fun warnLog(message: String) { |
There was a problem hiding this comment.
I think we can make this one internal even if it's been used in the hybrids
There was a problem hiding this comment.
We're still using this in PHC, will it work after setting it to internal?
There was a problem hiding this comment.
No... it's only two logs though... maybe we can do something so we can hide this in this SDK 🤔
There was a problem hiding this comment.
Well, if we make it internal, we can still log things in PHC/Hybrids... The consequence of that however is that those logs won't be redirected through the log handler in case the developer has set any. If we want to bypass that, we should wrap the log handler in PHC to set it in Android but also to redirect the messages in PHC. But honestly, if those logs are not very important, I would be ok if they are not redirected for now.
There was a problem hiding this comment.
Yes, I agree, I'd rather make this internal so we don't expose this to devs for no reason
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## bc6-support-new #1289 +/- ##
================================================
Coverage 85.61% 85.61%
================================================
Files 185 185
Lines 6313 6313
Branches 916 916
================================================
Hits 5405 5405
Misses 557 557
Partials 351 351
☔ View full report in Codecov by Sentry. |
|
Let's keep this open until the base branch is ready to go |
3c6cef9 to
ca82851
Compare
|
I've cherry-picked the commit in this PR into the #bc6-support-new branch because, after force-pushing that branch, there were a bunch of conflicts here. |
In preparation for BC6 support, I've modified the visibility of some classes, constants and functions to make them internal. Most of them are in the amazon package (they used to be public to be able to call them from other modules)
Note this is based off #1209