Future-proof in-app message APIs in case new types are added#1293
Merged
Conversation
21a7584 to
8e41ff8
Compare
tonidero
commented
Sep 27, 2023
| if (appConfig.showDeclinedPaymentMessagesAutomatically) { | ||
| showDeclinedPaymentMessageIfNeeded(activity) | ||
| if (appConfig.showInAppMessagesAutomatically) { | ||
| showInAppMessagesIfNeeded(activity, InAppMessageType.values().toList()) |
Contributor
Author
There was a problem hiding this comment.
When showing messages automatically, we show all types
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
+ Coverage 85.82% 85.83% +0.01%
==========================================
Files 185 186 +1
Lines 6314 6319 +5
Branches 916 918 +2
==========================================
+ Hits 5419 5424 +5
Misses 546 546
Partials 349 349 ☔ View full report in Codecov by Sentry. |
MarkVillacampa
approved these changes
Sep 27, 2023
Merged
MarkVillacampa
added a commit
that referenced
this pull request
Sep 28, 2023
### Breaking Changes * Support for Billing Client 6 (#1209) via Mark Villacampa (@MarkVillacampa) * Bump minimum sdk version to Android 4.4 (API level 19) (#1265) via Mark Villacampa (@MarkVillacampa) * in app messages support (#1290) via Andy Boedo (@aboedo) ### Bugfixes * Add `awaitRestore` to customEntitlementComputation library (#1275) via Toni Rico (@tonidero) ### Other Changes * Future-proof in-app message APIs in case new types are added (#1293) via Toni Rico (@tonidero) * `Code style`: enabled `ALLOW_TRAILING_COMMA` (#1280) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Followup to #1290.
This improves the API to future-proof them in case Google adds new in-app message types in the future. This is not a breaking change since the previous APIs haven't been released yet.