Skip to content

Add awaitRestore to customEntitlementComputation library#1275

Merged
tonidero merged 1 commit into
mainfrom
add-await-restore-custom-entitlement-computation-library
Sep 21, 2023
Merged

Add awaitRestore to customEntitlementComputation library#1275
tonidero merged 1 commit into
mainfrom
add-await-restore-custom-entitlement-computation-library

Conversation

@tonidero

Copy link
Copy Markdown
Contributor

Description

We moved the restore purchases functionality to the customEntitlementComputation library in #1211 but we didn't make the coroutines version available as well. This fixes that.

@tonidero tonidero added the pr:fix A bug fix label Sep 21, 2023

// endregion

// region awaitRestore

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just moving the tests. No changes.

@tonidero tonidero marked this pull request as ready for review September 21, 2023 07:42
@tonidero tonidero requested a review from a team September 21, 2023 07:42
@codecov

codecov Bot commented Sep 21, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (8573796) 85.94% compared to head (35d667d) 85.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1275   +/-   ##
=======================================
  Coverage   85.94%   85.94%           
=======================================
  Files         184      184           
  Lines        6274     6274           
  Branches      911      911           
=======================================
  Hits         5392     5392           
  Misses        536      536           
  Partials      346      346           
Files Changed Coverage Δ
...n/com/revenuecat/purchases/coroutinesExtensions.kt 82.60% <ø> (+0.46%) ⬆️
...revenuecat/purchases/CoroutinesExtensionsCommon.kt 84.00% <80.00%> (-1.00%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonidero tonidero merged commit 28ba6b0 into main Sep 21, 2023
@tonidero tonidero deleted the add-await-restore-custom-entitlement-computation-library branch September 21, 2023 12:30
@MarkVillacampa MarkVillacampa mentioned this pull request Sep 27, 2023
MarkVillacampa added a commit that referenced this pull request Sep 28, 2023
### Breaking Changes
* Support for Billing Client 6 (#1209) via Mark Villacampa
(@MarkVillacampa)
* Bump minimum sdk version to Android 4.4 (API level 19) (#1265) via
Mark Villacampa (@MarkVillacampa)
* in app messages support (#1290) via Andy Boedo (@aboedo)
### Bugfixes
* Add `awaitRestore` to customEntitlementComputation library (#1275) via
Toni Rico (@tonidero)
### Other Changes
* Future-proof in-app message APIs in case new types are added (#1293)
via Toni Rico (@tonidero)
* `Code style`: enabled `ALLOW_TRAILING_COMMA` (#1280) via NachoSoto
(@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants