periph/gpio: fix scope of GPIO_IRQ submodule#9992
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Oct 9, 2018
Merged
Conversation
Move the gpio_irq_enable() and gpio_irq_disable() functions into the scope of the PERIPH_GPIO_IRQ submodule.
This was referenced Sep 21, 2018
Merged
miri64
approved these changes
Oct 9, 2018
Member
miri64
left a comment
There was a problem hiding this comment.
ACK, just moves an #ifdef and everything still builds :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
See #9978
Move the gpio_irq_enable() and gpio_irq_disable() functions into the scope of the PERIPH_GPIO_IRQ submodule.
NOTE: this PR need all CPUs to be adapted to work correctly:
Testing procedure
Build and run
tests/periph_gpioin the default configuration and also withDISABLE_MODULE += periph_gpio_irq.Issues/PRs references
See #9978 for some context
#9845 for the changed that triggered this PR