Skip to content

cpu/kinetis/gpio: use gpio_irq feature#9998

Merged
jnohlgard merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:fix_gpioirq_kinetis
Sep 26, 2018
Merged

cpu/kinetis/gpio: use gpio_irq feature#9998
jnohlgard merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:fix_gpioirq_kinetis

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen commented Sep 21, 2018

See #9992

@haukepetersen haukepetersen mentioned this pull request Sep 21, 2018
Merged
16 tasks
jnohlgard
jnohlgard requested changes Sep 21, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not build. Needs ctx_clear to be declared before gpio_init_port

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Sep 21, 2018

oh damn, seems like cherry picked the commit from the wrong branch... Anyway, fixed (again).

jnohlgard
jnohlgard approved these changes Sep 21, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on frdm-kw41z, tests/periph_gpio, works.

@jnohlgard
Copy link
Copy Markdown
Member

jnohlgard commented Sep 21, 2018

please squash

@jnohlgard jnohlgard added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation and removed Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Sep 21, 2018
@jnohlgard jnohlgard added this to the Release 2018.10 milestone Sep 21, 2018
@jnohlgard jnohlgard self-assigned this Sep 21, 2018
@haukepetersen haukepetersen mentioned this pull request Sep 21, 2018
Closed
20 tasks
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Sep 26, 2018

squashed.

@jnohlgard jnohlgard merged commit 42463ab into RIOT-OS:master Sep 26, 2018
@jnohlgard
Copy link
Copy Markdown
Member

jnohlgard commented Sep 26, 2018

Thanks for improving the drivers!

@haukepetersen haukepetersen deleted the fix_gpioirq_kinetis branch September 26, 2018 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnohlgard jnohlgard jnohlgard approved these changes

Assignees

@jnohlgard jnohlgard

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.10

Development

Successfully merging this pull request may close these issues.

2 participants

@haukepetersen @jnohlgard