cpu/cc26x0/gpio: use gpio_irq feature#9999
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Oct 9, 2018
Merged
Conversation
This was referenced Sep 21, 2018
miri64
approved these changes
Oct 9, 2018
Member
There was a problem hiding this comment.
Tested the same way as I did #10008:
As far as I can tell (and checked with
colordiff -u <(git show | grep "^-" | sed 's/^-//g') <(git show | grep "^+" | sed 's/^+//g')) this just moves andifdefs some code around. After a local rebase to include #9981 I also was able to build this withtests/periph_gpioboth withperiph_gpio_irqmanually added or removed toFEATURES_OPTIONAL. Withoutperiph_gpio_irqthe binary is significantly smaller with this PR than in master.
I used cc2650-launchpad as a board for the compile tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9992