Skip to content

cpu/sam0_common/gpio: use gpio_irq feature#9996

Merged
dylad merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:fix_gpioirq_sam0_common
Sep 23, 2018
Merged

cpu/sam0_common/gpio: use gpio_irq feature#9996
dylad merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:fix_gpioirq_sam0_common

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen commented Sep 21, 2018

See #9992

This was referenced Sep 21, 2018
Merged
Closed
@dylad dylad added Platform: ARM Platform: This PR/issue effects ARM-based platforms CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 23, 2018
@dylad dylad added this to the Release 2018.10 milestone Sep 23, 2018
dylad
dylad approved these changes Sep 23, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK with arduino-zero and periph_tests with various tests on various pins.

@dylad
Copy link
Copy Markdown
Member

dylad commented Sep 23, 2018 •
edited
Loading

@haukepetersen DISABLE_MODULE += periph_gpio_irq leads to unsuccessful build because there is no guard in tests/periph_gpio. This issue is also true for others CPU implementations to me.
This should be fix before merging this one.

Edit: I leave my ACK because this must be fix somewhere else.

@jnohlgard
Copy link
Copy Markdown
Member

jnohlgard commented Sep 23, 2018

@dylad see #9981

@dylad
Copy link
Copy Markdown
Member

dylad commented Sep 23, 2018

Oh great it works once rebased, thanks @gebart :)

@dylad
Copy link
Copy Markdown
Member

dylad commented Sep 23, 2018

All green -> Go.

@dylad dylad merged commit 028bc2a into RIOT-OS:master Sep 23, 2018
@haukepetersen haukepetersen deleted the fix_gpioirq_sam0_common branch September 24, 2018 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylad dylad dylad approved these changes

Assignees

No one assigned

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms

Projects

None yet

Milestone

Release 2018.10

Development

Successfully merging this pull request may close these issues.

3 participants

@haukepetersen @dylad @jnohlgard