Skip to content

cpu/lpc2387/gpio: use gpio_irq feature#9997

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:fix_gpioirq_lpc2387
Oct 9, 2018
Merged

cpu/lpc2387/gpio: use gpio_irq feature#9997
miri64 merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:fix_gpioirq_lpc2387

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen commented Sep 21, 2018

See #9992

This was referenced Sep 21, 2018
Merged
Closed
@miri64 miri64 added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers labels Sep 27, 2018
miri64
miri64 approved these changes Oct 9, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the same way as I did #10008:

As far as I can tell (and checked with colordiff -u <(git show | grep "^-" | sed 's/^-//g') <(git show | grep "^+" | sed 's/^+//g')) this just moves and ifdefs some code around. After a local rebase to include #9981 I also was able to build this with tests/periph_gpio both with periph_gpio_irq manually added or removed to FEATURES_OPTIONAL. Without periph_gpio_irq the binary is significantly smaller with this PR than in master.

The size difference to master here isn't as significant (I tested with msba2; 18536 in master, 18516 in this PR without periph_gpio_irq) as for the Cortex-M boards I tested so far. But I don't see this as a cause for worry.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 9, 2018
@miri64
Copy link
Copy Markdown
Member

miri64 commented Oct 9, 2018 •
edited
Loading

This PR needed another level of diffing, because the move wasn't that obvious, but I checked this as well:

colordiff -u \
    <(diff -u <(git show | grep "^-" | sed 's/^-//g') \
              <(git show | grep "^+" | sed 's/^+//g') | grep "^-" | sed 's/^-//g') \
    <(diff -u <(git show | grep "^-" | sed 's/^-//g') \
              <(git show | grep "^+" | sed 's/^+//g') | grep "^+" | sed 's/^+//g')

@miri64 miri64 mentioned this pull request Oct 9, 2018
Merged
@miri64 miri64 merged commit 8e3a43b into RIOT-OS:master Oct 9, 2018
@miri64 miri64 deleted the fix_gpioirq_lpc2387 branch October 9, 2018 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

No one assigned

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haukepetersen @miri64