drivers/radios: remove default event reporting flags [backport 2018.07]#9601
Closed
bergzand wants to merge 4 commits intoRIOT-OS:2018.07-branchfrom
Closed
drivers/radios: remove default event reporting flags [backport 2018.07]#9601bergzand wants to merge 4 commits intoRIOT-OS:2018.07-branchfrom
bergzand wants to merge 4 commits intoRIOT-OS:2018.07-branchfrom
Conversation
7 tasks
Member
Author
|
Should be retested before merging |
Member
|
I've re-tested everything except openthread |
Member
|
@jia200x mind to check openthread again? |
Member
|
@bergzand @PeterKietzmann I confirm OpenThread is working (tested via IotLAB) |
Member
|
@bergzand please rebase |
Member
Author
|
@PeterKietzmann I was thinking of pushing the fixes from #9606 directly onto this backport PR. The commits from that PR fix some issues with the original version of this PR. We can also build a separate backport PR for those fixes, but I prefer to bundle them with this PR for the backport |
Member
Contributor
|
Yes please someone, @bergzand or @PeterKietzmann push the fixes from #9606 here. |
Member
|
I don't know how I can push to this PR so I opened #9679 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9577
Contribution description
Now that all network stacks set the required netdev event flags on init, these defaults can be removed from the radios. This prevents the radios from reporting events that are not handled by the network stack anyway.
Issues/PRs references
#9467, #9553, #9555, #9556
Testing
All current network stacks should be tested with at least one of the changed drivers to ensure that all required events for that network stack still work (testing on native (with socket_zep) is not enough).
@miri64 Did I miss a network stack that uses one of the modified 802.15.4 radios in this list?