gnrc_netif: Enable RX and TX complete events after netdev init#9467
Merged
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom Jul 9, 2018
Merged
Conversation
Member
PeterKietzmann
left a comment
There was a problem hiding this comment.
ACK from my side. Would like to wait for @miri64 before merging
PeterKietzmann
approved these changes
Jul 9, 2018
Member
PeterKietzmann
left a comment
There was a problem hiding this comment.
Did a routine test, pinging couple of thousand times between two iotlab-m3 nodes on the tested -> l2 netstats output looks as expected
miri64
reviewed
Jul 9, 2018
| static const netopt_enable_t enable = NETOPT_ENABLE; | ||
| int res = dev->driver->set(dev, NETOPT_RX_END_IRQ, &enable, sizeof(enable)); | ||
| if (res < 0) { | ||
| LOG_ERROR("gnrc_netif: enable NETOPT_RX_END_IRQ failed: %d\n", res); |
Member
There was a problem hiding this comment.
Couldn't that have been DEBUG? I now get this error message every time on native.
Member
Author
There was a problem hiding this comment.
You're right, DEBUG is probably better
This was referenced Jul 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
gnrc_netif expects NETOPT_RX_END_IRQ to be enabled by default, or else no packets will be received. All current netdev drivers enable some of these flags by default, but it seems hacky to depend on flag default values. With this change, the device drivers can be simplified and the preprocessor conditional on MODULE_NETSTATS_L2 for NETOPT_TX_END_IRQ can be removed from the device drivers as well.
Not sure how the other network stacks may be affected so there are no changes to the netdev device drivers in this PR.
Issues/PRs references