Skip to content

lwip: explicitly set required netdev events#9553

Merged
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
bergzand:pr/pkg/lwip/set_netdev_events
Jul 13, 2018
Merged

lwip: explicitly set required netdev events#9553
PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
bergzand:pr/pkg/lwip/set_netdev_events

Conversation

@bergzand
Copy link
Copy Markdown
Member

Contribution description

Similar to #9467, this modifies LwIP to explicitly set the NETOPT_RX_END_IRQ event for netdev devices.

Issues/PRs references

None

@bergzand bergzand added Area: network Area: Networking Area: pkg Area: External package ports labels Jul 12, 2018
@bergzand bergzand requested a review from miri64 July 12, 2018 10:06
@bergzand bergzand added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 12, 2018
@PeterKietzmann
Copy link
Copy Markdown
Member

Did you test this?

@bergzand
Copy link
Copy Markdown
Member Author

@PeterKietzmann I've tested with tests/lwip. I can send UDP frames from one instance to another on native.

@PeterKietzmann
Copy link
Copy Markdown
Member

Ah ok. Yes, native works here as well. On samr21-xpro I get the following assertion which might be unrelated.

main(): This is RIOT! (Version: 2018.07-devel-867-ge7deb-515b9e49740c-HEAD)
RIOT lwip test application
Assertion "increment_magnitude <= p->len" failed at /data/riotbuild/riotproject/tests/lwip/bin/pkg/samr21-xpro/lwip/src/core/pbuf.c:583
#! exit 1: powering off

@bergzand
Copy link
Copy Markdown
Member Author

Let's investigate that for a bit then...

@bergzand
Copy link
Copy Markdown
Member Author

@PeterKietzmann I'm unable to reproduce that on IoT-lab so far. Do you have more information on how to reproduce this?

@PeterKietzmann
Copy link
Copy Markdown
Member

I'm on your branch an flashed tests/lwip to one samr21-xpro board. Some seconds after startup the above mentioned assertion triggers

@PeterKietzmann
Copy link
Copy Markdown
Member

BTW: same on master...

@bergzand
Copy link
Copy Markdown
Member Author

Still nothing on my IoT-lab nodes. I would find it very strange if practically changing nothing causes assertion failures in the lwip packet buffer.

@PeterKietzmann
Copy link
Copy Markdown
Member

BTW: same on master...

It doesn't relate to your change. The same error persists on current master, without this PR. So we could theoretically merge this one. On the iotlab (with M3 node) I don't get the assertion either. Did you try the samr21-xpro in saclay?

@bergzand
Copy link
Copy Markdown
Member Author

Did you try the samr21-xpro in saclay?

Yes, node number 1 and 2 :)

@PeterKietzmann
Copy link
Copy Markdown
Member

Can you try to build in Docker and submit an other exp on samr nodes?

@bergzand
Copy link
Copy Markdown
Member Author

@PeterKietzmann Done, still nothing, works perfectly fine on this side 😢

@PeterKietzmann
Copy link
Copy Markdown
Member

Well, obviously this is not an issue with your PR. Seems more toolchain related. Will open an issue :/

Copy link
Copy Markdown
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@PeterKietzmann PeterKietzmann merged commit 446ff9f into RIOT-OS:master Jul 13, 2018
@PeterKietzmann
Copy link
Copy Markdown
Member

#9573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants