gnrc_netif: reapply event flags on device reset#9606
gnrc_netif: reapply event flags on device reset#9606PeterKietzmann merged 1 commit intoRIOT-OS:masterfrom
Conversation
On a NETOPT_STATE set call with NETOPT_STATE_RESET the netdev device resets the callback event flags. This requires that after the netdev device resets, the network stack also reapplies these callback event flags
91f4ddb to
30e683c
Compare
|
I only have boards with |
|
Why isn't that change needed for the other stacks as well? |
|
@miri64 how would you test this? |
|
@PeterKietzmann Take a board with a radio that doesn't have a |
|
Now that I looked at it I think changing "any value" for the interface makes no sense. Code-wise I agree with this change. @bergzand how did you determine this problem, which boards/which commands did you use? |
|
@PeterKietzmann I used a nucleo with the mrf24j40. I think the problem is not visible with the kw2xrf driver because it doesn't use extra settings for indicating which events should be propagated. Instead it always reports all events. |
PeterKietzmann
left a comment
There was a problem hiding this comment.
ACK. Tested as explained before but with a nucleo+mrf24j40 <-> samr21-xpro
On a NETOPT_STATE set call with NETOPT_STATE_RESET the netdev device
resets the callback event flags. This requires that after the netdev
device resets, the network stack also reapplies these callback event
flags
Issues/PRs references
Introduced with #9577 (This PR should be backported if #9577 is backported)
Testing
Due to #8118, this can't be tested on the at86rf2xx (this also does not fix the issue from #8118)