Revert #2936, #3123, #3168, #3172, #3181, #3209, #3232#3305
Revert #2936, #3123, #3168, #3172, #3181, #3209, #3232#3305AaronVanGeffen merged 1 commit intoOpenLoco:masterfrom
Conversation
|
While it's definitely an annoying bug, it seems a bit excessive to me to revert all of this work. I'll try to pitch in with the debugging. Bisecting should help narrow down the issue, right? |
The issue is the render target being relative while viewports store absolute coordinates, there is no middle ground for this, well I tried and it doesn't work. |
AaronVanGeffen
left a comment
There was a problem hiding this comment.
Messed around with a map for a fair bit, and tested various news items. None triggered a crash.
It sucks to have to revert a bunch of your work, though. Hopefully, we can reintroduce it in the near future.
It is what it is, I will look into doing this right in the future, I also don't like all this nested rendering logic, first UI then Viewport then more UI, this is just chaos. |
Missed in OpenLoco#3305
I currently don't know why its crashing in certain situations and why there are still artifacts when the newspaper is open, so until then lets revert all the changes that cause this behavior, its unfortunate but better to have this not crash and glitch, apologies.