Fix #3116: Visual artifacts with additional viewports#3181
Merged
duncanspumpkin merged 3 commits intoOpenLoco:masterfrom Aug 14, 2025
Merged
Fix #3116: Visual artifacts with additional viewports#3181duncanspumpkin merged 3 commits intoOpenLoco:masterfrom
duncanspumpkin merged 3 commits intoOpenLoco:masterfrom
Conversation
AaronVanGeffen
approved these changes
Aug 5, 2025
Member
AaronVanGeffen
left a comment
There was a problem hiding this comment.
Looks good to me. Could you add a changelog entry?
ZehMatt
added a commit
to ZehMatt/OpenLoco
that referenced
this pull request
Oct 6, 2025
ZehMatt
added a commit
to ZehMatt/OpenLoco
that referenced
this pull request
Oct 6, 2025
ZehMatt
added a commit
to ZehMatt/OpenLoco
that referenced
this pull request
Oct 6, 2025
AaronVanGeffen
pushed a commit
that referenced
this pull request
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My refactoring caused this, the issue is that viewports store their positions now relative to the parent (window) and it used that to shift the pixels which requires the absolute screen position. Viewports now store the owner so we can compute the correct position when the absolute one is needed, there was also an issue that invalidation didn't correctly work but on busy maps its hard to notice that.
Closes #3116