Clip render target for widgets, do not draw them with window relatives#3123
Merged
ZehMatt merged 2 commits intoOpenLoco:masterfrom Jul 8, 2025
Merged
Clip render target for widgets, do not draw them with window relatives#3123ZehMatt merged 2 commits intoOpenLoco:masterfrom
ZehMatt merged 2 commits intoOpenLoco:masterfrom
Conversation
duncanspumpkin
approved these changes
Jun 15, 2025
Contributor
duncanspumpkin
left a comment
There was a problem hiding this comment.
Seems sensible haven't tested it
Contributor
Author
|
I tested most of the things myself to see if any oddities stick out but would be good for another pair of eyes to have a look. |
This comment was marked as outdated.
This comment was marked as outdated.
AaronVanGeffen
approved these changes
Jul 8, 2025
Member
AaronVanGeffen
left a comment
There was a problem hiding this comment.
All fine as far as I'm concerned. I realise the viewport situation was resolved with a hack, but it's fine for now.
Windows tested
- About
- AboutMusic
- BuildVehicle
- Cheats
- CompanyFaceSelection
- CompanyList
- CompanyWindow
- Construction/ConstructionTab
- Construction/OverheadTab
- Construction/SignalTab
- Construction/StationTab
- DebugWindow
- DragVehiclePart
- Dropdown
- EditKeyboardShortcut
- Error
- IndustryList
- IndustryWindow
- KeyboardShortcuts
- LandscapeGeneration
- LandscapeGenerationConfirm
- Main
- MapToolTip
- MapWindow
- MessageWindow
- MusicSelection
- NetworkStatus
- News/News
- News/Ticker
- ObjectLoadError
- ObjectSelectionWindow
- Options
- PlayerInfoPanel
- ProgressBar
- PromptBrowseWindow
- PromptOkCancelWindow
- PromptSaveWindow
- ScenarioOptions
- ScenarioSelect
- StationList
- StationWindow
- TerraForm
- TextInputWindow
- TileInspector
- TimePanel
- TitleExit
- TitleLogo
- TitleMenu
- TitleOptions
- TitleVersion
- ToolbarBottomEditor
- ToolbarTop
- ToolbarTopAlt
- ToolbarTopCommon
- ToolTip
- TownList
- TownWindow
- Tutorial
- Vehicle
- VehicleList
ZehMatt
added a commit
to ZehMatt/OpenLoco
that referenced
this pull request
Oct 6, 2025
ZehMatt
added a commit
to ZehMatt/OpenLoco
that referenced
this pull request
Oct 6, 2025
ZehMatt
added a commit
to ZehMatt/OpenLoco
that referenced
this pull request
Oct 6, 2025
AaronVanGeffen
pushed a commit
that referenced
this pull request
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now windows and widgets will always use the local coordinate space for drawing.