Skip to content

Draw all widgets in windows relative position, also clip rt#2936

Merged
ZehMatt merged 58 commits intoOpenLoco:masterfrom
ZehMatt:relative-drawing
May 12, 2025
Merged

Draw all widgets in windows relative position, also clip rt#2936
ZehMatt merged 58 commits intoOpenLoco:masterfrom
ZehMatt:relative-drawing

Conversation

@ZehMatt
Copy link
Copy Markdown
Contributor

@ZehMatt ZehMatt commented Feb 17, 2025

All the window drawing is now clipped to the window region which means all subsequent draw calls will start at 0,0 of the window canvas rather than screen.

@ZehMatt ZehMatt force-pushed the relative-drawing branch from e0d9b1b to a4780c0 Compare May 9, 2025 09:20
@ZehMatt ZehMatt marked this pull request as ready for review May 9, 2025 12:15
@AaronVanGeffen AaronVanGeffen added this to the v25.04+ milestone May 9, 2025
@AaronVanGeffen
Copy link
Copy Markdown
Member

AaronVanGeffen commented May 12, 2025

Issues found:

  • CompanyList window: speed records are offset incorrectly (ribbon/final tab)
  • Construction/Common: tab images are offset incorrectly
  • Construction/OverheadTab: overhead dropdown is offset incorrectly
  • Construction/SignalTab: signal dropdown is offset incorrectly
  • Construction/StationTab: station dropdown is offset incorrectly
  • Industry window: y axis label offset incorrectly (production/second tab)
  • News/News window: viewport appear empty (offset incorrectly?)
  • Options window: autosave dropdown captions aren't drawn properly (misc/wrench tab)
  • Options window: volume slider is invisible (music tab, in-game only)
  • TextInputWindow: prompt is offset incorrectly (white text above input field)
  • Town window: status line is offset incorrectly (first tab)
  • Town window: population chart is offset incorrectly (second tab)
  • Town window: authority summary is offset incorrectly (third tab)
Windows tested

  • About
  • AboutMusic
  • BuildVehicle
  • Cheats
  • CompanyFaceSelection
  • CompanyList
  • CompanyWindow
  • Construction/ConstructionTab
  • Construction/OverheadTab
  • Construction/SignalTab
  • Construction/StationTab
  • DebugWindow
  • DragVehiclePart
  • EditKeyboardShortcut
  • Error
  • IndustryList
  • IndustryWindow
  • KeyboardShortcuts
  • LandscapeGeneration
  • LandscapeGenerationConfirm
  • Main
  • MapToolTip
  • MapWindow
  • MessageWindow
  • MusicSelection
  • NetworkStatus
  • News/News
  • News/Ticker
  • ObjectLoadError
  • ObjectSelectionWindow
  • Options
  • PlayerInfoPanel
  • ProgressBar
  • PromptBrowseWindow
  • PromptOkCancelWindow
  • PromptSaveWindow
  • ScenarioOptions
  • ScenarioSelect
  • StationList
  • StationWindow
  • TerraForm
  • TextInputWindow
  • TileInspector
  • TimePanel
  • TitleExit
  • TitleLogo
  • TitleMenu
  • TitleOptions
  • TitleVersion
  • ToolbarBottomEditor
  • ToolbarTop
  • ToolbarTopAlt
  • ToolbarTopCommon
  • ToolTip
  • TownList
  • TownWindow
  • Tutorial
  • Vehicle
  • VehicleList

Copy link
Copy Markdown
Member

@AaronVanGeffen AaronVanGeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aforementioned issues are confirmed fixed. Looks good to me!

@ZehMatt ZehMatt merged commit 9948c84 into OpenLoco:master May 12, 2025
10 checks passed
@ZehMatt ZehMatt deleted the relative-drawing branch May 12, 2025 20:14
@ZehMatt
Copy link
Copy Markdown
Contributor Author

ZehMatt commented Jul 8, 2025

This unfortunately added some weirdness.
OpenLoco_2025-07-09_00-41-361752010896

@LeeSpork
Copy link
Copy Markdown
Contributor

LeeSpork commented Jul 8, 2025

This unfortunately added some weirdness.

#3116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants