Skip to content

Fix issue 1506#5

Merged
MeniZalzman merged 1 commit intodevfrom
Issue1506
Oct 13, 2015
Merged

Fix issue 1506#5
MeniZalzman merged 1 commit intodevfrom
Issue1506

Conversation

@yishaigalatzer
Copy link
Copy Markdown
Contributor

@yishaigalatzer yishaigalatzer commented Oct 2, 2015

Fix issue NuGet/Home#1506

Primary:
Make BuildIntegratedNugetProject constructor fail gracefully when the project.json file is corrupt
Throw meaningful exception when reading the json file fails

Secondary
Ignore failures when constructing any nuget project, and handling gracefully (this is more of a defensive programming, not the real fix)

Fix issue 1506
2cea603 
Primary:
Make BuildIntegratedNugetProject constructor fail gracefully when the project.json file is corrupt
Throw meaningful exception when reading the json file fails

Secondary
Ignore failures when constructing any nuget project, and handling gracefully (this is more of a defensive programming, not the real fix)
MeniZalzman
MeniZalzman reviewed Oct 2, 2015
View reviewed changes
src/NuGet.Clients/PackageManagement.VisualStudio/IDE/NuGetAndEnvDTEProjectCache.cs
Copy link
Copy Markdown
Contributor

@MeniZalzman MeniZalzman Oct 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we decorate this method with the possible exception that can be thrown?

Copy link
Copy Markdown
Contributor Author

@yishaigalatzer yishaigalatzer Oct 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not practically 100% possible, so I prefer not to go in this mode. It is something we can start doing in the future when we build a proper public API

@MeniZalzman
Copy link
Copy Markdown
Contributor

MeniZalzman commented Oct 2, 2015

:shipit:

deepakaravindr
deepakaravindr reviewed Oct 13, 2015
View reviewed changes
src/NuGet.Core/NuGet.ProjectManagement/Projects/BuildIntegratedNuGetProject.cs
Copy link
Copy Markdown
Contributor

@deepakaravindr deepakaravindr Oct 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "ErrorLoadingPackagesConfig" the right string resource? We are dealing with project.json and not packages.config, right? Same comment for another use of this string resource in the file

@deepakaravindr
Copy link
Copy Markdown
Contributor

deepakaravindr commented Oct 13, 2015

:shipit: (Signed-off with comments)

@MeniZalzman MeniZalzman merged commit 2cea603 into dev Oct 13, 2015
@MeniZalzman
Copy link
Copy Markdown
Contributor

MeniZalzman commented Oct 13, 2015

Merged
eea288e

@MeniZalzman MeniZalzman deleted the Issue1506 branch October 13, 2015 21:41
@zivkan zivkan mentioned this pull request Aug 7, 2020
Merged
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 20 commits.
a67e66c 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 25 commits.
11e7376 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
# This is the commit message #21:

cleanup

# This is the commit message #22:

cleanup

# This is the commit message #23:

oops
# This is the commit message #24:

Clean up
# This is the commit message #25:

undo
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 20 commits.
edc0101 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 25 commits.
0380e40 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
# This is the commit message #21:

cleanup

# This is the commit message #22:

cleanup

# This is the commit message #23:

oops
# This is the commit message #24:

Clean up
# This is the commit message #25:

undo
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 28 commits.
ae2bdf2 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
# This is the commit message #21:

cleanup

# This is the commit message #22:

cleanup

# This is the commit message #23:

oops
# This is the commit message #24:

Clean up
# This is the commit message #25:

undo
# This is the commit message #26:

cleanup

# This is the commit message #27:

cleanup

# This is the commit message #28:

# This is a combination of 20 commits.
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yishaigalatzer @MeniZalzman @deepakaravindr @dnfclas