Skip to content

fixed https://github.com/NuGet/Home/issues/796#15

Closed
zhili1208 wants to merge 3 commits intodevfrom
fix796
Closed

fixed https://github.com/NuGet/Home/issues/796#15
zhili1208 wants to merge 3 commits intodevfrom
fix796

Conversation

@zhili1208
Copy link
Copy Markdown
Contributor

@zhili1208 zhili1208 commented Oct 8, 2015

NuGet/Home#796
the bug is unneeded file [Content_Types].xml are created during restore.
the fix is filter [Content_Types].xml in PackageExtraction.

yishaigalatzer
yishaigalatzer reviewed Oct 8, 2015
View reviewed changes
test/EndToEnd/tests/PackageRestoreTest.ps1 Outdated
Copy link
Copy Markdown
Contributor

@yishaigalatzer yishaigalatzer Oct 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a unit test instead of a functional test, and add a test for a package that has that file not at the root (make sure it is still extracted)

deepakaravindr
deepakaravindr reviewed Oct 13, 2015
View reviewed changes
test/NuGet.Core.Tests/NuGet.Packaging.Test/PackageExtractorTests.cs
Copy link
Copy Markdown
Contributor

@deepakaravindr deepakaravindr Oct 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the local variable 'test' you have created

@deepakaravindr
Copy link
Copy Markdown
Contributor

deepakaravindr commented Oct 13, 2015

:shipit: (Signed-off with comments)

@MeniZalzman
Copy link
Copy Markdown
Contributor

MeniZalzman commented Oct 14, 2015

:shipit: after fixing the comments

@zhili1208 zhili1208 closed this Oct 14, 2015
@zhili1208 zhili1208 deleted the fix796 branch October 19, 2015 17:38
@nkolev92 nkolev92 mentioned this pull request Apr 8, 2020
Merged
@nkolev92 nkolev92 mentioned this pull request Apr 24, 2020
Merged
@nkolev92 nkolev92 mentioned this pull request Aug 14, 2020
Merged
@nkolev92 nkolev92 mentioned this pull request Mar 4, 2022
Merged
5 tasks
TheCakeIsNaOH pushed a commit to TheCakeIsNaOH/NuGet.Client that referenced this pull request Jan 11, 2023
@gep13
Merge pull request NuGet#15 from AdmiringWorm/public-api-removals
adce539 
(NuGet#11) Add support for creating/updating api removals
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 20 commits.
a67e66c 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 25 commits.
11e7376 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
# This is the commit message #21:

cleanup

# This is the commit message #22:

cleanup

# This is the commit message #23:

oops
# This is the commit message #24:

Clean up
# This is the commit message #25:

undo
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 20 commits.
edc0101 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 25 commits.
0380e40 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
# This is the commit message #21:

cleanup

# This is the commit message #22:

cleanup

# This is the commit message #23:

oops
# This is the commit message #24:

Clean up
# This is the commit message #25:

undo
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 28 commits.
ae2bdf2 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
# This is the commit message #21:

cleanup

# This is the commit message #22:

cleanup

# This is the commit message #23:

oops
# This is the commit message #24:

Clean up
# This is the commit message #25:

undo
# This is the commit message #26:

cleanup

# This is the commit message #27:

cleanup

# This is the commit message #28:

# This is a combination of 20 commits.
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhili1208 @deepakaravindr @MeniZalzman @yishaigalatzer @dnfclas