Implemented nuget.exe add and nuget.exe init commands#14
Closed
deepakaravindr wants to merge 13 commits intodevfrom
Closed
Implemented nuget.exe add and nuget.exe init commands#14deepakaravindr wants to merge 13 commits intodevfrom
deepakaravindr wants to merge 13 commits intodevfrom
Conversation
Contributor
|
Contributor
Author
|
Member
There was a problem hiding this comment.
This doesn't really describe what the command is for
Contributor
There was a problem hiding this comment.
+1, we need to explain the offline feed concept here
Contributor
Author
There was a problem hiding this comment.
Discussed with @yishaigalatzer and updated the command description both for add and init. Check it out in the next iteration.
Member
|
|
Contributor
There was a problem hiding this comment.
Please check if we have a way to declare mandatory parameters
Contributor
Author
There was a problem hiding this comment.
No. We do not have a way today to declare mandatory parameters.
Contributor
|
|
… This will be used by nuget.exe add and nuget.exe init
user-defined offline feed as controlled by settings.
mandatory source and destination feed for add and init respectively. Need to fix tests
and destination feed for nuget.exe init mandatory.
and nuget.exe init using an -Expand switch. Need to add tests
…found. 2) Added more tests for nuget.exe init
Verified manually that it works. Need to add tests
simplify the not exists check on the path both for add and init commands. 2) Renamed ValidatePath to ThrowIfInvalid. 3) Added tests for OfflineFeedUtility
moved the tests to NugetPackageUtilTests.cs. Also, fixed the existing tests to use the new signature for InstallFromSourceAsync
b77d921 to
d6e75a7
Compare
Contributor
Author
TheCakeIsNaOH
pushed a commit
to TheCakeIsNaOH/NuGet.Client
that referenced
this pull request
Jan 6, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both nuget.exe add and nuget.exe init follows the new v3 model to only copy the nupkg, extract the nuspec and create a SHA512 of the nupkg file at the destination. With a provision to expand the packages using '-Expand' switch
nuget.exe add: NuGet/Home#1421
Adds a given package to the specified source if it is a file source. http sources are not supported.
nuget.exe init: NuGet/Home#1423
Adds all the packages from a given feed to the specified destination feed if it is a file source feed. http feeds are not supported.
Following are pending and/or not covered in this change.
@yishaigalatzer @MeniZalzman @emgarten