Conversation
There was a problem hiding this comment.
Most strings have a '{0}' and use LocalizedResourceManager to fill in the parameter instead of concatenating the strings like this is doing. I suggest using that instead to keep things consistent and clear.
There was a problem hiding this comment.
Please break long lines
|
⌚ |
There was a problem hiding this comment.
Could you use nameof instead of using a string for ClearCacheCommand_ClearingNuGetHttpCache. Same comment for other places
|
@bradwilson this one is for you |
There was a problem hiding this comment.
why not return a bool?
|
⌚ Please don't rebase before your next commit, so comments don't disappear. |
There was a problem hiding this comment.
I still don't see a fix for this comment. What infrequent exception is being thrown? And why can't we use the .NET implementation?
|
Will close this PR and send a new one to keep track of this discussion. |
NuGet/Home#1516
cc @emgarten @yishaigalatzer