Define s-table header styles using variables #2836
Conversation
jevenski
commented
Dec 23, 2024
- Define header background with CSS gradient or plain color.
- Control sorting icons using CSS class names.
- Define sorting icons with inline base64 strings and remove binary image files.
- Define header background with CSS gradient or plain color. - Control sorting icons using CSS class names. - Define sorting icons with inline base64 strings and remove binary image files.
517b8b9 to
aeaefcf
Compare
stickz
left a comment
There was a problem hiding this comment.
I'm okay with the font changes on the default theme. It actually looks bigger and better. We just need to increase the top and bottom padding, so it doesn't look like one big blob of text.
|
While we're at it, maybe add an ellipsis when the text is too long and overlaps desc/asc icon if possible. something like |
This is a good idea to implement, but it also brings up another question. In order to "ellipsis" the text overflow, we'll need to wrap the text in a new HTML element, and this will make the text alignment in table headers more complex. To simplify things, @stickz shall we set the text in table headers always centrally aligned, instead of dynamically setting different alignment for different columns (align to left for text columns, align to right for numeric columns). The cells in the table body are still aligned in this way. Only the cells in the table header are set to align centrally. Edit: After a second thought, I think we can delay this for a while, as I intend to merge the now separated table header and the table body into the same HTML table. The table header will need rewriting anyway. |
I'm okay with merging this pull request once the padding is adjusted. I like the idea of separate pull requests, even if it means creating a temporary regression. As long as we have a plan to resolve it before release. |
- Wrap texts in s-table headers with HTML `span`s, in order to apply styles to headers in the future. - Modify mouse cursor type on `span` elements accordingly, allowing only those in the General and Log tab pages show text cursors. - Increase padding on Y-axis for s-table cells.
**Full Changelog**: Novik/ruTorrent@v5.1.7...v5.2.1 # ruTorrent v5.2.1 This is a critical hotfix to resolve breakage of RSS feeds. It's highly recommended to upgrade. In addition, the white border is fixed on dark themes. A stopped state is also added to torrents. ## What's Changed * Adding Stopped state by ranirahn in Novik/ruTorrent#2893 * Fix for broken RSS feeds break the rutorrent. by ranirahn in Novik/ruTorrent#2894 * Fix white border in dark themes by drrako in Novik/ruTorrent#2898 **Full Changelog**: Novik/ruTorrent@v5.2.0...v5.2.1 # ruTorrent v5.2.0 is now Stable This is a release contains more mobile design improvements, performance improvements and various new features. It builds on progress made in ruTorrent `v5.1` toward mobile development. ## Critical Improvement Summary 1. Torrents now have bigger font to make them easier to read. 2. There is no more drag mask when moving around dialog boxes. 3. Internet explorer is no longer supported. (Yes finally, we dropped it) 4. Various performance improvements to tables to improve responsiveness. 5. The clear log now has a bootstrap button in the bottom right corner. 6. Many other smaller improvements, bug fixes and new features. ## What's Changed * Fix torrent deleted without confirmation by koblack in Novik/ruTorrent#2804 * filedrop plugin: support dropped links by pekman in Novik/ruTorrent#2806 * Remove drag mask object by jevenski in Novik/ruTorrent#2805 * Covert clear log to a floating button by jevenski in Novik/ruTorrent#2810 * Use bootstrap dropdown on recent trackers by jevenski in Novik/ruTorrent#2809 * Use flex layout on context menu items by jevenski in Novik/ruTorrent#2812 * Adjust status bar and top menu by jevenski in Novik/ruTorrent#2813 * Define dialog window colors using variables by jevenski in Novik/ruTorrent#2815 * Distribute WebUi space using flex layout by jevenski in Novik/ruTorrent#2826 * Remove Internet Explorer support, and some useragent sniffing hacks by anthonyryan1 in Novik/ruTorrent#2825 * Change various s-table methods by jevenski in Novik/ruTorrent#2821 * Define status bar icons using base64 strings by jevenski in Novik/ruTorrent#2833 * Animate category panel by jevenski in Novik/ruTorrent#2831 * Define getter functions on s-table by jevenski in Novik/ruTorrent#2830 * Use bootstrap list group on options window by jevenski in Novik/ruTorrent#2819 * Define s-table header styles using variables by jevenski in Novik/ruTorrent#2836 * Improve s-table column resizing by jevenski in Novik/ruTorrent#2837 * Control alternate row color using CSS by jevenski in Novik/ruTorrent#2841 * Improve move column function by jevenski in Novik/ruTorrent#2844 * Improve s-table header row hover event handler by jevenski in Novik/ruTorrent#2851 * Drag and drop s-table header using DnD class by jevenski in Novik/ruTorrent#2855 * Merge stable head and body into one table by jevenski in Novik/ruTorrent#2860 * Add danger color to #randomize_hash by anthonyryan1 in Novik/ruTorrent#2875 * Fix various bugs for v5.2 by jevenski in Novik/ruTorrent#2863 * Let rutracker_check ignore torrents with certain labels by drrako in Novik/ruTorrent#2866 * Add "::1" to localhost address list. by rozhuk-im in Novik/ruTorrent#2881 * Improve $tempDirectory handling: by rozhuk-im in Novik/ruTorrent#2880 * Diskspace option to display free bytes (new pull request against develop branch) by TheGoblinHero in Novik/ruTorrent#2890 * Add a permission to hide all torrent options by fffe in Novik/ruTorrent#2868 * Mark ruTorrent v5.2 as Stable by stickz in Novik/ruTorrent#2891 ## New Contributors * pekman made their first contribution in Novik/ruTorrent#2806 * rozhuk-im made their first contribution in Novik/ruTorrent#2881 **Full Changelog**: Novik/ruTorrent@v5.1.7...v5.2.0