Change various s-table methods #2821

jevenski · 2024-12-10T01:58:36Z

Adjust s-table's createRow() method to use jQuery to create table rows. This is more readable than generating table rows
with HTML strings.
Rewrite toggleColumn to use jQuery's toggle() method to toggle table cell display and use jQuery's selector function to replace a for loop.
Deprecate calcSize() method with a deprecation warning since we're unifying behaviors on different browsers. This method will be removed in the next major version update.

jevenski · 2024-12-10T01:59:31Z

css/style.css

  background-color: var(--container-bg-color);
 }

-.stable-icon {background-image: url(../images/tstatus.png); background-repeat: no-repeat}


Move to stable.css

jevenski · 2024-12-10T02:00:48Z

js/stable.js

-			).join('');
-	if(!browser.isIE7x)
-	{
+	row.find("td:first-child div").prepend(this.createIcon(icon));


Append an icon to the first cell in a row directly, without having to check for the cell index on every cell.

jevenski · 2024-12-10T02:03:52Z

js/stable.js

-		: $('<span>').addClass(['stable-icon', icon]))[0].outerHTML;
+dxSTable.prototype.createIconHTML = function(icon) {
+	// TODO: deprecated, remove this method in v6
+	noty("Deprecation warning: `dxSTable.createIconHTML()` is deprecated. Please use `dxSTable.createIcon()` instead.");


Add a deprecation warning to prevent sudden API breakage.

jevenski · 2024-12-10T02:10:29Z

js/stable.js

-				td: [
-					`<td class="stable-${this.dCont.id}-col-${ind}"`,
-					Boolean(cdat.enabled || browser.isIE7x) ?	'>' : ' style="display: none">',
-					ind === 0 ? this.createIconHTML(icon) : ''


This conditional runs on every cell. If there are 25 cells in a row, and 1,000 rows in a table, there will be 24 * 1,000 = 24,000 unnecessary checks.

jevenski · 2024-12-10T02:14:16Z

plugins/theme/themes/DarkBetter/style.css

    background-image: url(./images/tb_search.svg);
    background-image: url(./images/tb_rss.svg);
-    background-image: url(./images/rb_rss_group.svg);
+    background-image: url(./images/tb_rss_group.svg);


jevenski · 2024-12-10T02:14:37Z

plugins/theme/themes/DarkBetter/style.css

    background-image: url(./images/pnl_close.svg);
    background-image: url(./images/file.svg);
    background-image: url(./images/dir.svg);
-    background-image: url(./images/dir.svg);


jevenski · 2024-12-10T02:21:24Z

plugins/theme/themes/DarkBetter/style.css

    background-image: url(./images/plugin.svg);
-    background-image: url(./images/yellow.svg);
-    background-image: url(./images/red.svg);
-    background-image: url(./images/green.svg);


js/stable.js

stickz · 2024-12-12T18:12:27Z

The text is too close to the icon for the torrent name. Please increase spacing to match v5.1.

stickz · 2024-12-16T01:59:30Z

@jevenski I rebased this for you. Great job with the performance improvements.

However, when I resize a column the header and body goes out of sync. This critical issue needs fixed before I can merge.

- Adjust s-table's `createRow()` method to use jQuery to create table rows. This is more readable than generating table rows with HTML strings. - Rewrite `toggleColumn` to use jQuery's `toggle()` method to toggle table cell display and use jQuery's selector function to replace a for loop. - Deprecate `calcSize()` method with a deprecation warning since we're unifying behaviors on different browsers. This method will be removed in the next major version update.

jevenski · 2024-12-16T05:24:22Z

@stickz I did some modification to this patch and force pushed again. Previous changes are all squashed into one commit. Additionally, an old s-table method (.calcSize()) is removed and marked for deprecation to unify APP behaviors on different browsers and sync cell width between s-table header and body.

stickz · 2024-12-16T05:36:49Z

All fixed, great job!

**Full Changelog**: Novik/ruTorrent@v5.1.7...v5.2.1 # ruTorrent v5.2.1 This is a critical hotfix to resolve breakage of RSS feeds. It's highly recommended to upgrade. In addition, the white border is fixed on dark themes. A stopped state is also added to torrents. ## What's Changed * Adding Stopped state by ranirahn in Novik/ruTorrent#2893 * Fix for broken RSS feeds break the rutorrent. by ranirahn in Novik/ruTorrent#2894 * Fix white border in dark themes by drrako in Novik/ruTorrent#2898 **Full Changelog**: Novik/ruTorrent@v5.2.0...v5.2.1 # ruTorrent v5.2.0 is now Stable This is a release contains more mobile design improvements, performance improvements and various new features. It builds on progress made in ruTorrent `v5.1` toward mobile development. ## Critical Improvement Summary 1. Torrents now have bigger font to make them easier to read. 2. There is no more drag mask when moving around dialog boxes. 3. Internet explorer is no longer supported. (Yes finally, we dropped it) 4. Various performance improvements to tables to improve responsiveness. 5. The clear log now has a bootstrap button in the bottom right corner. 6. Many other smaller improvements, bug fixes and new features. ## What's Changed * Fix torrent deleted without confirmation by koblack in Novik/ruTorrent#2804 * filedrop plugin: support dropped links by pekman in Novik/ruTorrent#2806 * Remove drag mask object by jevenski in Novik/ruTorrent#2805 * Covert clear log to a floating button by jevenski in Novik/ruTorrent#2810 * Use bootstrap dropdown on recent trackers by jevenski in Novik/ruTorrent#2809 * Use flex layout on context menu items by jevenski in Novik/ruTorrent#2812 * Adjust status bar and top menu by jevenski in Novik/ruTorrent#2813 * Define dialog window colors using variables by jevenski in Novik/ruTorrent#2815 * Distribute WebUi space using flex layout by jevenski in Novik/ruTorrent#2826 * Remove Internet Explorer support, and some useragent sniffing hacks by anthonyryan1 in Novik/ruTorrent#2825 * Change various s-table methods by jevenski in Novik/ruTorrent#2821 * Define status bar icons using base64 strings by jevenski in Novik/ruTorrent#2833 * Animate category panel by jevenski in Novik/ruTorrent#2831 * Define getter functions on s-table by jevenski in Novik/ruTorrent#2830 * Use bootstrap list group on options window by jevenski in Novik/ruTorrent#2819 * Define s-table header styles using variables by jevenski in Novik/ruTorrent#2836 * Improve s-table column resizing by jevenski in Novik/ruTorrent#2837 * Control alternate row color using CSS by jevenski in Novik/ruTorrent#2841 * Improve move column function by jevenski in Novik/ruTorrent#2844 * Improve s-table header row hover event handler by jevenski in Novik/ruTorrent#2851 * Drag and drop s-table header using DnD class by jevenski in Novik/ruTorrent#2855 * Merge stable head and body into one table by jevenski in Novik/ruTorrent#2860 * Add danger color to #randomize_hash by anthonyryan1 in Novik/ruTorrent#2875 * Fix various bugs for v5.2 by jevenski in Novik/ruTorrent#2863 * Let rutracker_check ignore torrents with certain labels by drrako in Novik/ruTorrent#2866 * Add "::1" to localhost address list. by rozhuk-im in Novik/ruTorrent#2881 * Improve $tempDirectory handling: by rozhuk-im in Novik/ruTorrent#2880 * Diskspace option to display free bytes (new pull request against develop branch) by TheGoblinHero in Novik/ruTorrent#2890 * Add a permission to hide all torrent options by fffe in Novik/ruTorrent#2868 * Mark ruTorrent v5.2 as Stable by stickz in Novik/ruTorrent#2891 ## New Contributors * pekman made their first contribution in Novik/ruTorrent#2806 * rozhuk-im made their first contribution in Novik/ruTorrent#2881 **Full Changelog**: Novik/ruTorrent@v5.1.7...v5.2.0

jevenski commented Dec 10, 2024

View reviewed changes

jevenski force-pushed the create-row branch 2 times, most recently from 32b6354 to 89e4249 Compare December 10, 2024 02:20

jevenski commented Dec 10, 2024

View reviewed changes

jevenski force-pushed the create-row branch from 89e4249 to 5e57459 Compare December 10, 2024 04:41

stickz requested changes Dec 10, 2024

View reviewed changes

js/stable.js Outdated Show resolved Hide resolved

stickz added enhancement v5.2 labels Dec 10, 2024

jevenski mentioned this pull request Dec 11, 2024

Backport fixes for DarkBetter theme icons #2822

Merged

anthonyryan1 mentioned this pull request Dec 13, 2024

Remove Internet Explorer support, and some useragent sniffing hacks #2825

Merged

stickz force-pushed the create-row branch 2 times, most recently from 2aedc46 to 0155aec Compare December 16, 2024 01:44

jevenski force-pushed the create-row branch from 0155aec to 6bfe314 Compare December 16, 2024 05:17

jevenski changed the title ~~Create s-table rows using jQuery DOM manipulation~~ Change various s-table methods Dec 16, 2024

stickz merged commit 5061f71 into Novik:develop Dec 16, 2024

jevenski deleted the create-row branch December 16, 2024 05:45

stickz mentioned this pull request Apr 27, 2025

ruTorrent: Upgrade to v5.2.1 crazy-max/docker-rtorrent-rutorrent#434

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Change various s-table methods #2821

Change various s-table methods #2821

Uh oh!

jevenski commented Dec 10, 2024 •

edited

Loading

Uh oh!

jevenski Dec 10, 2024

Uh oh!

jevenski Dec 10, 2024

Uh oh!

jevenski Dec 10, 2024

Uh oh!

jevenski Dec 10, 2024 •

edited

Loading

Uh oh!

jevenski Dec 10, 2024

Uh oh!

jevenski Dec 10, 2024

Uh oh!

jevenski Dec 10, 2024

Uh oh!

Uh oh!

stickz commented Dec 12, 2024

Uh oh!

stickz commented Dec 16, 2024

Uh oh!

jevenski commented Dec 16, 2024

Uh oh!

stickz commented Dec 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Change various s-table methods #2821

Change various s-table methods #2821

Uh oh!

Conversation

jevenski commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jevenski Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

jevenski Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

jevenski Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

jevenski Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jevenski Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

jevenski Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

jevenski Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stickz commented Dec 12, 2024

Uh oh!

stickz commented Dec 16, 2024

Uh oh!

jevenski commented Dec 16, 2024

Uh oh!

stickz commented Dec 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jevenski commented Dec 10, 2024 •

edited

Loading

jevenski Dec 10, 2024 •

edited

Loading