Skip to content

Conversation

@jevenski
Copy link
Contributor

@jevenski jevenski commented Dec 3, 2024

This patch contains some unnoticeable changes by non-developers. It serves mainly for a clean-up purpose.

  • Change status bar position to static because height of the navbar, the main content and the status bar has been set to be calculated dynamically according to the window height.
  • Define status bar border color and background color using css variables, with CSS gradient for background in use in some themes (Excel, Oblivion).
  • Remove verbose utility class names on status bar.
  • Remove unused outdated CSS rules.
  • Set a max height on the collapsible navbar menu to fit in some extreme situations where one might have a screen with small height or a collapsible menu with a lot of buttons.

@jevenski jevenski force-pushed the status-bar branch 3 times, most recently from 28d24a0 to c938023 Compare December 3, 2024 10:32
- Change status bar position to static because height of the navbar,
  the main content and the status bar has been set to be calculated
  dynamically according to the window height.
- Define status bar border color and background color using css
  variables, with CSS gradient for background in use in some themes
  (Excel, Oblivion).
- Remove verbose utility class names on status bar.
- Remove unused outdated CSS rules.
- Set a max height on the collapsible navbar menu to fit in some
  extreme situations where one might have a screen with small height
  or a collapsible menu with a lot of buttons.
@stickz
Copy link
Collaborator

stickz commented Dec 4, 2024

There is a problem with webui resizing introduced by this pull request.

Resize web browser window to mobile and open the topmenu. Keep it open and resize back to desktop.
white_background

The background for the menu items on desktop changes to white. The topmenu for mobile remains open on resize.

- Fix top menu collapsing when opening dialog windows on mobile.
- Fix top menu not collapsing when switching from mobile to desktop.
@jevenski
Copy link
Contributor Author

jevenski commented Dec 5, 2024

This is an old bug introduced by an earlier commit. The new commit also fixes this issue: #2814

@stickz stickz added the bug label Dec 5, 2024
@stickz stickz linked an issue Dec 5, 2024 that may be closed by this pull request
4 tasks
@stickz stickz merged commit 036d8a9 into Novik:develop Dec 5, 2024
@jevenski jevenski deleted the status-bar branch December 5, 2024 15:56
stickz added a commit to stickz/docker-rtorrent-rutorrent that referenced this pull request Apr 27, 2025
**Full Changelog**: Novik/ruTorrent@v5.1.7...v5.2.1

# ruTorrent v5.2.1
This is a critical hotfix to resolve breakage of RSS feeds. It's highly recommended to upgrade.
In addition, the white border is fixed on dark themes. A stopped state is also added to torrents.

## What's Changed
* Adding Stopped state by ranirahn in Novik/ruTorrent#2893
* Fix for broken RSS feeds break the rutorrent. by ranirahn in Novik/ruTorrent#2894
* Fix white border in dark themes by drrako in Novik/ruTorrent#2898

**Full Changelog**: Novik/ruTorrent@v5.2.0...v5.2.1

# ruTorrent v5.2.0 is now Stable
This is a release contains more mobile design improvements, performance improvements and various new features. It builds on progress made in ruTorrent `v5.1` toward mobile development. 

## Critical Improvement Summary

1. Torrents now have bigger font to make them easier to read.
2. There is no more drag mask when moving around dialog boxes.
3. Internet explorer is no longer supported. (Yes finally, we dropped it)
4. Various performance improvements to tables to improve responsiveness.
5. The clear log now has a bootstrap button in the bottom right corner.
6. Many other smaller improvements, bug fixes and new features.

## What's Changed
* Fix torrent deleted without confirmation by koblack in Novik/ruTorrent#2804
* filedrop plugin: support dropped links by pekman in Novik/ruTorrent#2806
* Remove drag mask object by jevenski in Novik/ruTorrent#2805
* Covert clear log to a floating button by jevenski in Novik/ruTorrent#2810
* Use bootstrap dropdown on recent trackers by jevenski in Novik/ruTorrent#2809
* Use flex layout on context menu items by jevenski in Novik/ruTorrent#2812
* Adjust status bar and top menu by jevenski in Novik/ruTorrent#2813
* Define dialog window colors using variables by jevenski in Novik/ruTorrent#2815
* Distribute WebUi space using flex layout by jevenski in Novik/ruTorrent#2826
* Remove Internet Explorer support, and some useragent sniffing hacks by anthonyryan1 in Novik/ruTorrent#2825
* Change various s-table methods by jevenski in Novik/ruTorrent#2821
* Define status bar icons using base64 strings by jevenski in Novik/ruTorrent#2833
* Animate category panel by jevenski in Novik/ruTorrent#2831
* Define getter functions on s-table by jevenski in Novik/ruTorrent#2830
* Use bootstrap list group on options window by jevenski in Novik/ruTorrent#2819
* Define s-table header styles using variables by jevenski in Novik/ruTorrent#2836
* Improve s-table column resizing by jevenski in Novik/ruTorrent#2837
* Control alternate row color using CSS by jevenski in Novik/ruTorrent#2841
* Improve move column function by jevenski in Novik/ruTorrent#2844
* Improve s-table header row hover event handler by jevenski in Novik/ruTorrent#2851
* Drag and drop s-table header using DnD class by jevenski in Novik/ruTorrent#2855
* Merge stable head and body into one table by jevenski in Novik/ruTorrent#2860
* Add danger color to #randomize_hash by anthonyryan1 in Novik/ruTorrent#2875
* Fix various bugs for v5.2 by jevenski in Novik/ruTorrent#2863
* Let rutracker_check ignore torrents with certain labels by drrako in Novik/ruTorrent#2866
* Add "::1" to localhost address list. by rozhuk-im in Novik/ruTorrent#2881
* Improve $tempDirectory handling: by rozhuk-im in Novik/ruTorrent#2880
* Diskspace option to display free bytes (new pull request against develop branch) by TheGoblinHero in Novik/ruTorrent#2890
* Add a permission to hide all torrent options by fffe in Novik/ruTorrent#2868
* Mark ruTorrent v5.2 as Stable by stickz in Novik/ruTorrent#2891

## New Contributors
* pekman made their first contribution in Novik/ruTorrent#2806
* rozhuk-im made their first contribution in Novik/ruTorrent#2881

**Full Changelog**: Novik/ruTorrent@v5.1.7...v5.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collapsible top nav bar opens when dialog is opened

2 participants