Skip to content

Conversation

@jevenski
Copy link
Contributor

  • Resize category list, torrent list table and torrent detail tabs using flex-basis property. This reduces the amount of JS doing resizing work and lets CSS take over the space distribution.
  • Add a deprecation warning for the old theWebUI.resizeTop(w, h) method and suggest using the new simplified theWebUI.resizeTop(h) method.
  • Fix an error that occurs when traffic graph is shrinked down to less than 1px high.

Fixes #2817

- Resize category list, torrent list table and torrent detail tabs
  using `flex-basis` property. This reduces the amount of JS doing
  resizing work and lets CSS take over the space distribution.
- Add a deprecation warning for the old `theWebUI.resizeTop(w, h)`
  method and suggest using the new simplified `theWebUI.resizeTop(h)`
  method.
- Fix an error that occurs when traffic graph is shrinked down to
  less than 1px high.
@jevenski
Copy link
Contributor Author

This patch also fixes this issue mentioned in an early feedback for v5.0.

I also found that clicking on certain tabs in all the other themes causes the whole bottom section to grow vertically by 1 or 2 pixels. The tabs that do this the most often are the history and plugins tabs, but it happens with others depending on the theme. (Incidentally, this doesn't happen in the MaterialDesign theme.) I thought that it might be caused by the content of the active tab having x-overflow content, which could cause the scrollbar to appear and maybe bump the tab upward. But it happens even if I make the various fields in each tab narrower so that everything fits on the screen, so I'm not sure what's really making it happen. This isn't a big usability issue or anything. It's just a quirky UI thing where I can see the tab bar moving slightly up and down as I click through the tabs.

Originally posted by @Airman8 in #2721 (comment)

@stickz
Copy link
Collaborator

stickz commented Dec 14, 2024

@jevenski This will be the next pull request merged. Afterwards, we need a hotfix for all platforms on v5.1 (without the deprecation). There's an issue when I take my web browser out of maximize mode. The traffic graph does not update.
ruTorrent_max

ruTorrent_max2

@koblack
Copy link
Contributor

koblack commented Dec 14, 2024

Toggle details [F6] does not work correctly.
After pressing [F6] only the contents of the tab are hidden but this part of the window remains visible.

Screenshot:
image

- Fix toggle torrent detail tab pages error.
- Fix incorrect traffic graph dimension when maximizing and unmaximize
  browser window.
- Fix torrent list height minor shifting issue.
@stickz
Copy link
Collaborator

stickz commented Dec 15, 2024

Thanks @jevenski. I'll tag ruTorrent v5.1.4 once this is backported for a hotfix!

@stickz stickz merged commit cc511a9 into Novik:develop Dec 15, 2024
@jevenski jevenski deleted the flex-resize branch December 15, 2024 09:56
stickz added a commit to stickz/docker-rtorrent-rutorrent that referenced this pull request Apr 27, 2025
**Full Changelog**: Novik/ruTorrent@v5.1.7...v5.2.1

# ruTorrent v5.2.1
This is a critical hotfix to resolve breakage of RSS feeds. It's highly recommended to upgrade.
In addition, the white border is fixed on dark themes. A stopped state is also added to torrents.

## What's Changed
* Adding Stopped state by ranirahn in Novik/ruTorrent#2893
* Fix for broken RSS feeds break the rutorrent. by ranirahn in Novik/ruTorrent#2894
* Fix white border in dark themes by drrako in Novik/ruTorrent#2898

**Full Changelog**: Novik/ruTorrent@v5.2.0...v5.2.1

# ruTorrent v5.2.0 is now Stable
This is a release contains more mobile design improvements, performance improvements and various new features. It builds on progress made in ruTorrent `v5.1` toward mobile development. 

## Critical Improvement Summary

1. Torrents now have bigger font to make them easier to read.
2. There is no more drag mask when moving around dialog boxes.
3. Internet explorer is no longer supported. (Yes finally, we dropped it)
4. Various performance improvements to tables to improve responsiveness.
5. The clear log now has a bootstrap button in the bottom right corner.
6. Many other smaller improvements, bug fixes and new features.

## What's Changed
* Fix torrent deleted without confirmation by koblack in Novik/ruTorrent#2804
* filedrop plugin: support dropped links by pekman in Novik/ruTorrent#2806
* Remove drag mask object by jevenski in Novik/ruTorrent#2805
* Covert clear log to a floating button by jevenski in Novik/ruTorrent#2810
* Use bootstrap dropdown on recent trackers by jevenski in Novik/ruTorrent#2809
* Use flex layout on context menu items by jevenski in Novik/ruTorrent#2812
* Adjust status bar and top menu by jevenski in Novik/ruTorrent#2813
* Define dialog window colors using variables by jevenski in Novik/ruTorrent#2815
* Distribute WebUi space using flex layout by jevenski in Novik/ruTorrent#2826
* Remove Internet Explorer support, and some useragent sniffing hacks by anthonyryan1 in Novik/ruTorrent#2825
* Change various s-table methods by jevenski in Novik/ruTorrent#2821
* Define status bar icons using base64 strings by jevenski in Novik/ruTorrent#2833
* Animate category panel by jevenski in Novik/ruTorrent#2831
* Define getter functions on s-table by jevenski in Novik/ruTorrent#2830
* Use bootstrap list group on options window by jevenski in Novik/ruTorrent#2819
* Define s-table header styles using variables by jevenski in Novik/ruTorrent#2836
* Improve s-table column resizing by jevenski in Novik/ruTorrent#2837
* Control alternate row color using CSS by jevenski in Novik/ruTorrent#2841
* Improve move column function by jevenski in Novik/ruTorrent#2844
* Improve s-table header row hover event handler by jevenski in Novik/ruTorrent#2851
* Drag and drop s-table header using DnD class by jevenski in Novik/ruTorrent#2855
* Merge stable head and body into one table by jevenski in Novik/ruTorrent#2860
* Add danger color to #randomize_hash by anthonyryan1 in Novik/ruTorrent#2875
* Fix various bugs for v5.2 by jevenski in Novik/ruTorrent#2863
* Let rutracker_check ignore torrents with certain labels by drrako in Novik/ruTorrent#2866
* Add "::1" to localhost address list. by rozhuk-im in Novik/ruTorrent#2881
* Improve $tempDirectory handling: by rozhuk-im in Novik/ruTorrent#2880
* Diskspace option to display free bytes (new pull request against develop branch) by TheGoblinHero in Novik/ruTorrent#2890
* Add a permission to hide all torrent options by fffe in Novik/ruTorrent#2868
* Mark ruTorrent v5.2 as Stable by stickz in Novik/ruTorrent#2891

## New Contributors
* pekman made their first contribution in Novik/ruTorrent#2806
* rozhuk-im made their first contribution in Novik/ruTorrent#2881

**Full Changelog**: Novik/ruTorrent@v5.1.7...v5.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants