Skip to content

fix(cli): restore MiniMax doctor health-check skip (regression)#8079

Closed
vinsew wants to merge 1 commit into
NousResearch:mainfrom
vinsew:fix/minimax-doctor-health-check
Closed

fix(cli): restore MiniMax doctor health-check skip (regression)#8079
vinsew wants to merge 1 commit into
NousResearch:mainfrom
vinsew:fix/minimax-doctor-health-check

Conversation

@vinsew

@vinsew vinsew commented Apr 12, 2026

Copy link
Copy Markdown

Summary

  • Restores supports_health_check=False for both MiniMax and MiniMax (China) entries in hermes doctor's _apikey_providers list
  • Adds a regression test to prevent re-enabling the flag

Problem

d442f25a ("fix: align MiniMax provider with official API docs") re-enabled the /v1/models health check for MiniMax, assuming the OpenAI-compat /v1 surface supports /models even though the Anthropic-compat /anthropic surface does not. That assumption is incorrect — neither surface exposes /v1/models:

$ curl -s -o /dev/null -w "%{http_code}" https://api.minimax.io/v1/models
404
$ curl -s -o /dev/null -w "%{http_code}" https://api.minimaxi.com/v1/models
404

The real chat endpoint works fine (POST /v1/text/chatcompletion_v2 → 200), so the runtime agent path is unaffected. Only hermes doctor is broken: every user with a MINIMAX_API_KEY or MINIMAX_CN_API_KEY sees a spurious ⚠ MiniMax (HTTP 404) warning.

This was originally fixed in #811 (which set the flag to False), and d442f25a inadvertently reverted that fix.

Fix

Restores the pre-d442f25a behavior:

Test plan

  • New test test_minimax_provider_health_check_disabled in tests/hermes_cli/test_doctor.py — fails if the flag gets re-enabled
  • Full test_doctor.py suite passes (18/18)
  • Manually verified with hermes doctor — MiniMax now shows ✓ MiniMax (China) (key configured) instead of ⚠ MiniMax (China) (HTTP 404)

Tested on macOS (Darwin 25.3.0), Python 3.11.4, Hermes 27eeea05.

Refs: #811

@vinsew vinsew mentioned this pull request Apr 12, 2026
Open
@vinsew vinsew force-pushed the fix/minimax-doctor-health-check branch from ee3f797 to b1dc76c Compare April 16, 2026 20:08
This was referenced Apr 22, 2026
Closed
Open
Closed
Open
@vinsew
fix(cli): restore MiniMax doctor health-check skip (regression from d…
108da94 
…442f25)

d442f25 re-enabled the /v1/models health check for both MiniMax and
MiniMax (China) in hermes doctor, assuming the OpenAI-compat /v1 surface
supports /models even though the Anthropic-compat /anthropic surface does
not. That assumption is incorrect — neither surface exposes /v1/models:

  curl https://api.minimax.io/v1/models   → HTTP 404
  curl https://api.minimaxi.com/v1/models → HTTP 404

The real chat endpoint (POST /v1/text/chatcompletion_v2) works fine, so
the runtime agent path is unaffected. Only hermes doctor is broken: every
user with a MINIMAX_API_KEY or MINIMAX_CN_API_KEY sees a spurious
⚠ MiniMax (HTTP 404) warning.

This restores the pre-d442f25a behavior (supports_health_check=False,
default_url=None) and adds a regression test so the flag cannot be
silently re-enabled.

Refs: NousResearch#811
@vinsew vinsew force-pushed the fix/minimax-doctor-health-check branch from b1dc76c to 108da94 Compare April 27, 2026 10:06
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard provider/minimax MiniMax (Anthropic transport) labels Apr 27, 2026
@alt-glitch

alt-glitch commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Multiple competing PRs for the same MiniMax health-check skip: #13780, #12403, #15520. Maintainers should pick one and close the rest.

@vinsew

vinsew commented Apr 27, 2026

Copy link
Copy Markdown
Author

Thanks for flagging the duplicates. Quick objective comparison for whoever picks this up:

PR Created Scope Test
#8079 (this) 2026-04-12 both global + CN endpoints yes (regression guard)
#12403 2026-04-19 both, but URL/base_url retained as dead config no
#13780 2026-04-22 CN only no
#15520 2026-04-25 CN only no

Two points the CN-only PRs don't address:

1. Global endpoint also 404s — not just CN:

$ curl -s -o /dev/null -w "%{http_code}\n" https://api.minimax.io/v1/models
404
$ curl -s -o /dev/null -w "%{http_code}\n" https://api.minimaxi.com/v1/models
404

PRs #13780 / #15520 leave global probing, so users with MINIMAX_API_KEY set will still see false 404 warnings in hermes doctor.

2. This is a regression — d442f25a ("fix: align MiniMax provider with official API docs") re-enabled a health check that a prior commit had correctly disabled. The included test_minimax_provider_health_check_disabled guards against the next iteration of the same well-intentioned fix flipping it back a third time.

Happy to close this in favor of any of the others if the picked PR covers both endpoints.

@vinsew

vinsew commented May 8, 2026

Copy link
Copy Markdown
Author

Closing — upstream has settled on the equivalent fix.

After d2ea959fe fix(doctor): skip /models health check for MiniMax CN (merged 2026-04-25), the doctor no longer probes /models for MiniMax-CN, which is the same end-state this PR was producing via supports_health_check=False. The remaining diff here is just a different code path to the identical behavior, plus a couple of competing PRs (#13780, #12403, #15520) for the same surface.

No need for the maintainers to triage between four PRs that all want the same outcome. Closing.

@vinsew vinsew closed this May 8, 2026
@vinsew vinsew deleted the fix/minimax-doctor-health-check branch May 13, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have provider/minimax MiniMax (Anthropic transport) type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vinsew @alt-glitch