Skip to content

fix(doctor): skip /models health check for MiniMax CN (returns 404)#15520

Closed
zng8418 wants to merge 1 commit into
NousResearch:mainfrom
zng8418:fix/minimax-cn-doctor-404
Closed

fix(doctor): skip /models health check for MiniMax CN (returns 404)#15520
zng8418 wants to merge 1 commit into
NousResearch:mainfrom
zng8418:fix/minimax-cn-doctor-404

Conversation

@zng8418

@zng8418 zng8418 commented Apr 25, 2026

Copy link
Copy Markdown

Summary

MiniMax China (api.minimaxi.com) does not expose a /v1/models endpoint. The hermes doctor was surfacing a false HTTP 404 warning even though the API works correctly for /v1/chat/completions.

Fix

Set supports_health_check=False for MiniMax CN, same approach used for OpenCode Go.

Refs #12768, #13757

MiniMax China (api.minimaxi.com) does not expose a /v1/models endpoint.
The doctor command was probing it and reporting HTTP 404 as a warning,
even though the API works correctly for chat completions.

Set supports_health_check=False for MiniMax CN so doctor shows
"(key configured)" instead of the false 404 warning.

Refs NousResearch#12768, NousResearch#13757
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard provider/minimax MiniMax (Anthropic transport) labels Apr 25, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Competing fix with #12162, #14123, and #8079 — all address the same MiniMax-CN /v1/models 404 false positive. Closes #12768, #13757.

@teknium1

teknium1 commented May 4, 2026

Copy link
Copy Markdown
Contributor

Salvaged via #19663 onto current main - your commit authorship was preserved. Thanks!

@teknium1 teknium1 closed this May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have provider/minimax MiniMax (Anthropic transport) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants