Skip to content

fix(doctor): skip MiniMax CN invalid models probe#14123

Closed
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/minimax-cn-doctor-health-12768
Closed

fix(doctor): skip MiniMax CN invalid models probe#14123
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/minimax-cn-doctor-health-12768

Conversation

@LeonSGP43

@LeonSGP43 LeonSGP43 commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • stop treating MiniMax China as a provider with a shared GET /models health endpoint
  • show the provider as configured instead of surfacing a false HTTP 404 in hermes doctor
  • add a regression test covering default, /anthropic, and /v1 MiniMax-CN base URLs

Testing

  • pytest -o addopts= tests/hermes_cli/test_doctor.py -k "minimax_cn_skips_invalid_models_probe or opencode_go_skips_invalid_models_probe"
  • pytest -o addopts= tests/hermes_cli/test_doctor.py

Closes #12768
Refs #13757

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard provider/minimax MiniMax (Anthropic transport) labels Apr 22, 2026
@alt-glitch

alt-glitch commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Competing fix with #12800 (same MiniMax-CN /models 404 issue). Also related to #12162. All address #12768 / #13757.

This was referenced Apr 23, 2026
Closed
Closed
Closed
@teknium1

teknium1 commented May 24, 2026

Copy link
Copy Markdown
Contributor

Closing as already fixed on main.

Triage notes (high confidence):
origin/main hermes_cli/doctor.py:265 already sets MiniMax (China) tuple with supports_health_check=False, and _probe_apikey_provider (doctor.py:1514) short-circuits to '(key configured)' when that flag is False — so the /models probe is already skipped.

If you still see this on the latest version, please reopen with reproduction steps.

(Bulk-closed during a CLI triage sweep.)

@teknium1 teknium1 closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists provider/minimax MiniMax (Anthropic transport) type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] hermes doctor: MiniMax (China) health check returns HTTP 404 despite functional API

3 participants

@LeonSGP43 @alt-glitch @teknium1