Skip to content

fix(doctor): skip MiniMax China models probe#12800

Closed
OwenYWT wants to merge 1 commit into
NousResearch:mainfrom
OwenYWT:fix/minimax-cn-doctor-health
Closed

fix(doctor): skip MiniMax China models probe#12800
OwenYWT wants to merge 1 commit into
NousResearch:mainfrom
OwenYWT:fix/minimax-cn-doctor-health

Conversation

@OwenYWT

@OwenYWT OwenYWT commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • treat MiniMax (China) as configured in hermes doctor instead of probing GET /v1/models
  • avoid a false HTTP 404 warning for a provider whose inference endpoint is functional
  • add a regression test ensuring doctor does not call httpx.get for MiniMax China

Fixes #12768.

Test plan

  • /Users/wentao/miniconda3/bin/python -m pytest -o addopts='' tests/hermes_cli/test_doctor.py -q
  • git diff --cached --check

@OwenYWT OwenYWT force-pushed the fix/minimax-cn-doctor-health branch from a0d6f15 to e3dd553 Compare April 20, 2026 03:43
@OwenYWT OwenYWT marked this pull request as ready for review April 20, 2026 04:34
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard provider/minimax MiniMax (Anthropic transport) labels Apr 23, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #14123 — both skip MiniMax China /models probe in hermes doctor. Both fix #12768.

@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #14123.

@teknium1

Copy link
Copy Markdown
Contributor

Closing as already fixed on main.

Triage notes (high confidence):
Main hermes_cli/doctor.py:265 already sets MiniMax (China) probe flag to False, so doctor no longer probes the unsupported /v1/models endpoint.

If you still see this on the latest version, please reopen with reproduction steps.

(Bulk-closed during a CLI triage sweep.)

@teknium1 teknium1 closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have provider/minimax MiniMax (Anthropic transport) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] hermes doctor: MiniMax (China) health check returns HTTP 404 despite functional API

3 participants