fix(doctor): skip /models health check for MiniMax CN (no such endpoint)#19663
Merged
Conversation
MiniMax China (api.minimaxi.com) does not expose a /v1/models endpoint. The doctor command was probing it and reporting HTTP 404 as a warning, even though the API works correctly for chat completions. Set supports_health_check=False for MiniMax CN so doctor shows "(key configured)" instead of the false 404 warning. Refs #12768, #13757
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #15520 onto current main.
Summary
MiniMax China (
api.minimaxi.com) doesn't expose a/v1/modelsendpoint.hermes doctorwas surfacing a false HTTP 404 warning even though/v1/chat/completionsworks correctly. Setsupports_health_check=Falsefor the MiniMax CN row so doctor skips the /models probe.Validation
Manual review of diff against current main.
Original PR: #15520