fix(doctor): skip /models health check for MiniMax-CN (Closes #13757)#13780
fix(doctor): skip /models health check for MiniMax-CN (Closes #13757)#13780ms-alan wants to merge 1 commit into
Conversation
MiniMax-CN (api.minimaxi.com) does not have a /v1/models endpoint (returns 404). The existing entry was marked True (supports check) with the wrong URL. Follow the same pattern as OpenCode Go — set url=None and _supports_health_check=False so it prints '(key configured)' without probing a non-existent endpoint. Closes NousResearch#13757
|
I have verified this solution by inspecting the code changes. The fix correctly sets and for the MiniMax-CN provider in the doctor command. This prevents false-positive 404 errors when the endpoint is probed, as MiniMax-CN (api.minimaxi.com) does not support this endpoint. The fix follows the established pattern used for other providers like OpenCode Go.\n\nTested and confirmed. ✅ |
|
Closing as superseded by #19663. Triage notes (high confidence): Thanks for the contribution — the underlying problem this PR addresses has been resolved by the linked PR on current main. If you believe this was closed in error, please comment and we'll reopen. (Bulk-closed during a CLI PR triage sweep.) |
Summary
MiniMax-CN (
api.minimaxi.com) does not have a/v1/modelsendpoint — it returns HTTP 404. The health check was incorrectly configured with a URL and_supports_health_check=True, causing a spurious failure.Follow the same pattern as OpenCode Go: set
url=Noneand_supports_health_check=Falsesohermes doctorprints(key configured)without probing a non-existent endpoint.Changes
hermes_cli/doctor.py: MiniMax-CN entry changed from(url, True)to(None, False)Testing
curl -s -o /dev/null -w "%{http_code}" "https://api.minimaxi.com/v1/models"→ 404curl -s -X POST "https://api.minimaxi.com/v1/chat/completions" ...→ 200Closes #13757