fix: skip MiniMax health check to avoid false 404 on /v1/models (#12399)#12403
Open
vominh1919 wants to merge 1 commit into
Open
fix: skip MiniMax health check to avoid false 404 on /v1/models (#12399)#12403vominh1919 wants to merge 1 commit into
vominh1919 wants to merge 1 commit into
Conversation
MiniMax's /v1/models endpoint returns 404 even when the API key is valid and chat completions work fine. This caused 'hermes doctor' to show a warning (HTTP 404) for a perfectly functional provider. Set _supports_health_check to False for both MiniMax and MiniMax (China), showing 'key configured' instead of hitting the broken endpoint. Fixes NousResearch#12399
Collaborator
This was referenced Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hermes doctorcallsGET /v1/modelson MiniMax base URL and reports a warning(HTTP 404)even though MiniMax chat completions work fine — MiniMax simply doesn't implement this endpoint.Fix
Set
_supports_health_checktoFalsefor both MiniMax and MiniMax (China) in the_apikey_providerslist inhermes_cli/doctor.py. This skips the GET /v1/models call and shows "key configured" instead, matching the pattern already used for OpenCode Go.Fixes #12399