fix(skills): add agentskills.io spec compliance for tags/platforms frontmatter#33968
Closed
alaamohanad169-ship-it wants to merge 2 commits into
Closed
Conversation
…view When frontmatter 'metadata' is not a dict (e.g. string or None from YAML), calling metadata.get() raises AttributeError. This broke skill_view and cascaded into all build_skill_invocation_message callers. Fix: extract metadata tags/related_skills with isinstance guard before use, matching the existing pattern for hermes_meta.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds agentskills.io spec compliance so skills can place platforms/tags under a metadata key, with full backward compatibility.
Changes
Bugfix
Original commit crashed when frontmatter metadata was non-dict — metadata.get() raised AttributeError. Fixed with isinstance guard.
Testing
All 178 skill-related tests pass. Zero failures.