Skip to content

fix(skills): agentskills.io spec compliance for tags/platforms frontmatter#31352

Closed
alaamohanad169-ship-it wants to merge 1 commit into
NousResearch:mainfrom
alaamohanad169-ship-it:fix/skills-spec-compliance
Closed

fix(skills): agentskills.io spec compliance for tags/platforms frontmatter#31352
alaamohanad169-ship-it wants to merge 1 commit into
NousResearch:mainfrom
alaamohanad169-ship-it:fix/skills-spec-compliance

Conversation

@alaamohanad169-ship-it

Copy link
Copy Markdown
Contributor

Summary

Makes Hermes skill loading backward-compatible with the agentskills.io spec (adopted by Anthropic, NVIDIA, 40+ clients). Skills with tags, platforms, and related_skills under metadata: now load correctly alongside the existing top-level format.

Changes

  • agent/prompt_builder.py:929 — fallback to metadata.platforms
  • agent/skill_utils.py:148 — fallback to metadata.platforms
  • tools/skills_tool.py:1277 — fallback to metadata.tags and metadata.related_skills
  • tests/agent/test_skill_utils.py — 6 new tests for agentskills.io format compliance

Fully backward-compatible: existing skills with top-level fields work unchanged.

Fixes #30080

@alaamohanad169-ship-it

Copy link
Copy Markdown
Contributor Author

Note to maintainers: This is a clean PR cherry-picked onto the latest main. Previous versions (#30978, #31241) were closed due to merge conflicts with upstream changes. This version is based on the current main HEAD and contains only the agentskills.io spec compliance changes:

  • agent/prompt_builder.py — fallback to metadata.platforms
  • agent/skill_utils.py — fallback to metadata.platforms
  • tools/skills_tool.py — fallback to metadata.tags and metadata.related_skills
  • tests/agent/test_skill_utils.py — 6 new tests

Fully backward-compatible. Fixes #30080.

@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) comp/agent Core agent loop, run_agent.py, prompt builder labels May 24, 2026
@alaamohanad169-ship-it

Copy link
Copy Markdown
Contributor Author

Clean PR on latest main. Adds agentskills.io spec compliance for tags, platforms, and related_skills under metadata: block. Fully backward-compatible. +60 -4.

@alaamohanad169-ship-it

Copy link
Copy Markdown
Contributor Author

Closed — replaced by a clean rebased PR. The original branch had accumulated unintended diff pollution from a bad rebase. The new PR contains only the focused fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent loop, run_agent.py, prompt builder P3 Low — cosmetic, nice to have tool/skills Skills system (list, view, manage) type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strict agentskills.io spec compliance: move tags/platforms under metadata in skill frontmatter

2 participants