fix(skills): agentskills.io spec compliance for tags/platforms frontmatter (rebased)#31241
Closed
alaamohanad169-ship-it wants to merge 5 commits into
Closed
Conversation
…ontmatter The agentskills.io spec (adopted by Anthropic, NVIDIA, 40+ clients) places agent-specific fields under metadata: instead of top-level. This makes Hermes skill loading backward-compatible with both formats: - Also read platforms from metadata.platforms (fallback from top-level) - Also read tags from metadata.tags (fallback from metadata.hermes.tags) - Also read related_skills from metadata (fallback from top-level) All 3 loader sites updated: - agent/prompt_builder.py:929 — platforms list building - agent/skill_utils.py:140 — platform matching - tools/skills_tool.py:1277 — tags/related_skills parsing Fully backward-compatible: existing skills with top-level fields work unchanged. Fixes NousResearch#30080
6 new tests: - test_platforms_top_level_still_works: legacy top-level platforms field - test_platforms_under_metadata_fallback: metadata.platforms fallback - test_metadata_platforms_fallback_when_top_level_absent: verified fallback with mock - test_metadata_tags_fallback_in_parse_frontmatter: metadata.tags in frontmatter - test_tags_top_level_still_read_by_skill_manage: top-level tags parsing - test_tags_metadata_fallback: _parse_tags with agentskills.io format
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes Hermes skill loading backward-compatible with the agentskills.io spec (adopted by Anthropic, NVIDIA, 40+ clients). Skills with
tagsandplatformsundermetadata:now load correctly alongside the existing top-level format.Problem
Issue #30080: Skills using the agentskills.io spec (fields under
metadata:block) were not recognized by Hermes.Changes
agent/prompt_builder.py:929— fallback tometadata.platformsagent/skill_utils.py:140— same fallback for platform matchingtools/skills_tool.py:1277— fallback tometadata.tagsandmetadata.related_skillstests/agent/test_skill_utils.py— 6 new tests + resolved merge conflict with Termux platform testsFully backward-compatible. Fixes #30080.
Note: Clean rebase of previously closed #30978, cherry-picked onto latest main.