fix(skills): add agentskills.io spec compliance for tags/platforms frontmatter#30105
Closed
alaamohanad169-ship-it wants to merge 1 commit into
Closed
Conversation
f7c9f5f to
8680394
Compare
This was referenced May 22, 2026
Contributor
Author
|
Closing this PR — it was stale (far behind upstream main with test conflicts). Superseded by #30978 which is the clean rebased version. |
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes Hermes skill loading backward-compatible with the agentskills.io spec (adopted by Anthropic, NVIDIA, 40+ clients). Skills with
tagsandplatformsundermetadata:now load correctly alongside the existing top-level format.Problem
Issue #30080: The agentskills.io spec places agent-specific fields under
metadata:instead of top-level. NVIDIA's 155 verified skills usemetadata.tagsandmetadata.platforms. Hermes only reads top-leveltags/platforms, so these spec-compliant skills are silently ignored.Fix
3 loader sites updated to check both locations:
agent/prompt_builder.py:929platformsmetadata.platformsagent/skill_utils.py:140platformsmetadata.platformstools/skills_tool.py:1277tagsmetadata.hermes.tags→ top-level →metadata.tagstools/skills_tool.py:1278related_skillsmetadata.hermes.related_skills→ top-level →metadata.related_skillsAll changes are single-line backward-compatible fallbacks. Existing skills with top-level fields are unaffected.
Testing
metadata.platformsinstead of top-levelmetadata.tagsinstead of top-levelFixes #30080