fix(skills): agentskills.io spec compliance for tags/platforms frontmatter#31579
Closed
alaamohanad169-ship-it wants to merge 1 commit into
Closed
Conversation
Collaborator
Contributor
Author
✅ Ready to MergeAll CI checks are green and this PR is mergeable. Summary: fix(skills): agentskills.io spec compliance for tags/platforms frontmatter CI Status: All 6 test slices passing, lint clean, no conflicts. Requesting merge when convenient. Thanks! |
0ba6744 to
6a2ad08
Compare
Contributor
Author
|
🔄 Rebased onto latest main (0219b04). All conflicts resolved. CI green. Ready for review. |
This was referenced May 25, 2026
6a2ad08 to
0c0c1c7
Compare
Contributor
Author
|
Note: This is NOT a duplicate of the prior closed PRs (#30105, #30978, #31241, #31352, #30080). |
Contributor
Author
|
Superseded by #33968 (clean rebase with bugfix). Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds agentskills.io spec compliance for skill frontmatter. The spec places agent-specific fields under
metadata:instead of top-level. This change makes Hermes skill loading backward-compatible with both formats:metadata.platforms(fallback from top-level)metadata.tags(fallback frommetadata.hermes.tags)metadata(fallback from top-level)All 3 loader sites updated:
agent/prompt_builder.py— platforms list buildingagent/skill_utils.py— platform matchingtools/skills_tool.py— tags/related_skills parsingFully backward-compatible: existing skills with top-level fields work unchanged.
Tests
6 new tests in
tests/agent/test_skill_utils.pycovering both legacy and agentskills.io formats.Changes
agent/prompt_builder.py: fallback tometadata.platformsagent/skill_utils.py: fallback tometadata.platformsinskill_matches_platform()tools/skills_tool.py: fallback tometadata.tags/metadata.related_skillstests/agent/test_skill_utils.py: 6 new regression testsFixes #30080
Replaces #31352 — rebased cleanly onto current main to remove unintended diff pollution.