Skip to content

fix: preserve Ctrl+J newlines in Ghostty#33193

Closed
seppegadeyne wants to merge 1 commit into
NousResearch:mainfrom
seppegadeyne:fix/ghostty-ctrl-j-newline
Closed

fix: preserve Ctrl+J newlines in Ghostty#33193
seppegadeyne wants to merge 1 commit into
NousResearch:mainfrom
seppegadeyne:fix/ghostty-ctrl-j-newline

Conversation

@seppegadeyne

@seppegadeyne seppegadeyne commented May 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Preserve Ctrl+J/Ctrl+Enter newline behavior in Ghostty sessions, including tmux-inherited Ghostty environments.
  • Keep plain Enter mapped to submit for local POSIX terminals that still need LF-as-submit compatibility.
  • Add CLI and TUI regression coverage for the Ghostty Ctrl+J newline path.

Verification

  • venv/bin/python -m pytest tests/cli/test_ctrl_enter_newline.py tests/cli/test_cli_init.py -q → 52 passed
  • npm test -- src/__tests__/textInputPassThrough.test.ts in ui-tui/ → 6 passed

Notes

  • A system-Python pytest attempt failed before using the project venv because optional test dependencies such as prompt_toolkit/python-dotenv and pytest-timeout were not available in system Python. The venv run above is the relevant verification.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard comp/tui Terminal UI (ui-tui/ + tui_gateway/) labels May 27, 2026
@alt-glitch

alt-glitch commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Fixes #9299. Competing open PRs for Ctrl+J/newline: #25111, #22911 (most comprehensive — also handles Warp), #26086, #27688.

@seppegadeyne

seppegadeyne commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the pointer — I missed the existing issue/competing PRs before opening this. Sorry for the duplicate review noise.

I agree this overlaps with #9299 and the open Ctrl+J/newline PRs (#25111, #22911, #26086, #27688). The only intended extra scope in this PR is:

  • Ghostty detection that survives tmux masking TERM / TERM_PROGRAM via the stable GHOSTTY_* env markers
  • TUI handling/tests for the same bare-LF / Ctrl+J behavior in Ghostty
  • focused verification for the Ghostty-on-Linux case I hit locally

I don’t want to fragment the review further. Maintainers, what would you prefer?

  1. I close this PR and move the Ghostty/TUI testcase/patch as a comment or suggested diff onto the canonical PR, likely fix(cli): preserve classic multiline on macOS #22911.
  2. I keep this PR open as a Ghostty/TUI-specific variant and update the body to Refs #9299.
  3. I rework this on top of whichever PR you choose as canonical.

Unless there’s a preference to keep this separate, I’m happy to close this and transfer the unique Ghostty/TUI bits to the canonical thread.

@teknium1 teknium1 mentioned this pull request May 29, 2026
Merged
teknium1 added a commit that referenced this pull request May 29, 2026
@teknium1
chore(release): map seppe@fushia.be to GitHub login
71ae98b 
Required by CI author validation after salvaging PR #33193.
KKT-OPT pushed a commit to KKT-OPT/hermes-agent that referenced this pull request May 31, 2026
@teknium1 @KKT-OPT
chore(release): map seppe@fushia.be to GitHub login
9c03df3 
Required by CI author validation after salvaging PR NousResearch#33193.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/tui Terminal UI (ui-tui/ + tui_gateway/) P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seppegadeyne @alt-glitch