fix(cli): preserve Ctrl-J newline on macOS#25111
Open
ForgedFinancial wants to merge 3 commits into
Open
Conversation
Collaborator
1 similar comment
Collaborator
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Treat native macOS like other preserved environments for Ctrl+J/Ctrl+Enter newline handling.\n- Keep Enter bound to submit while preventing c-j from being bound to submit on macOS.\n- Add regression coverage for macOS preserve behavior and submit binding separation.\n\n## Verification\n- venv/bin/python -m pytest -q -n 0 tests/cli/test_ctrl_enter_newline.py tests/cli/test_cli_init.py::TestPromptToolkitTerminalCompatibility::test_lf_enter_binds_to_submit_handler_posix\n- Direct assertion: macos_ctrl_j_submit_disabled=PASS\n- Canonical bootstrap ctrl-j check: HERMES_MACOS_CTRL_J_SUBMIT_DISABLED=1