fix(cli): preserve classic multiline on macOS#22911
Open
LeonSGP43 wants to merge 1 commit into
Open
Conversation
Contributor
|
Verified this covers the Apple Terminal regression I hit after #22777:
I checked out this PR and ran the focused CLI coverage locally: The |
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
c-jreserved for newline in the classic CLI on local macOS, so Shift+Enter paths that collapse to LF stop submitting the promptHERMES_CLI_SUBMIT_ON_LF=1Closes #22908.
Why this stays narrow
cli.py#22909remains separateVerification
git diff --check./.venv/bin/python -m pytest tests/cli/test_cli_init.py tests/cli/test_ctrl_enter_newline.py tests/cli/test_cli_shift_enter_newline.pyuv sync --frozen --extra alluv run --frozen ruff check .env -i PATH="$PATH" HOME="$HOME" TERM="${TERM:-xterm-256color}" TZ=UTC LANG=C.UTF-8 LC_ALL=C.UTF-8 PYTHONHASHSEED=0 ./.venv/bin/python -m pytest -o addopts= --collect-only --ignore=tests/integration --ignore=tests/e2e -m 'not integration'ruff/tylint-diff againstb67ea7ff474831743b14edefb6c9113cb12216e7(touched files:0newtydiagnostics)Left out