fix(cli): make Ctrl+J insert newline on macOS#26086
Open
dr4lamb wants to merge 1 commit into
Open
Conversation
Collaborator
3 tasks
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On macOS,
Ctrl+J(ASCII LF /c-j) is the wire encoding ofCtrl+Enter— a distinct keystroke from plainEnter(c-m). macOS terminal users naturally expectCtrl+Jto insert a newline (likeAlt+Enteron Linux), but instead it submits the message.Changes
Added
sys.platform == "darwin"to_preserve_ctrl_enter_newline()so thatc-jis left unbound from submit on macOS. The existingc-j → newlinehandler (originally added for Windows/WSL/SSH in issue #22379) then fires correctly.This is a 2-line logical change that extends the existing pattern to macOS.
Related