fix(delegate): tool_trace false-positive error detection for short outputs#26374
Closed
flooryyyy wants to merge 1 commit into
Closed
fix(delegate): tool_trace false-positive error detection for short outputs#26374flooryyyy wants to merge 1 commit into
flooryyyy wants to merge 1 commit into
Conversation
Contributor
Author
teknium1
added a commit
that referenced
this pull request
May 17, 2026
…tors Adds release-note attribution mappings for 10 contributors from the low-hanging-fruit salvage group 2 batch: - @shellybotmoyer (PR #26661, #25576) - @ether-btc (PR #26632) - @LifeJiggy (PR #26516) - @nekwo (PR #26481) - @flooryyyy (PR #26374) - @dgians (PR #26034, incl. zealy-tzco bot-committer alias) - @flanny7 (PR #27030) - @hermesagent26 (PR #26438) - @kriscolab (PR #26926, co-author on salvage commit)
Contributor
|
Merged via PR #27292 — your commit was cherry-picked onto current |
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…tors Adds release-note attribution mappings for 10 contributors from the low-hanging-fruit salvage group 2 batch: - @shellybotmoyer (PR NousResearch#26661, NousResearch#25576) - @ether-btc (PR NousResearch#26632) - @LifeJiggy (PR NousResearch#26516) - @nekwo (PR NousResearch#26481) - @flooryyyy (PR NousResearch#26374) - @dgians (PR NousResearch#26034, incl. zealy-tzco bot-committer alias) - @flanny7 (PR NousResearch#27030) - @hermesagent26 (PR NousResearch#26438) - @kriscolab (PR NousResearch#26926, co-author on salvage commit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The delegate_tool tool_trace marked successful tool calls as
"status": "error"when the output was short.Root cause: the error detection heuristic checked if the substring
"error"appeared in the first 80 chars of the tool result:For short JSON outputs like:
{"output":"test1\n","exit_code":0,"error":null}The
"error"key (from"error":null) lands within the first 80 chars → false positive flagged as error.This only affected the TUI overlay display and tool_trace diagnostics — the tool itself executed successfully. Long outputs avoided the bug because the
"error"key was pushed past the 80-char window.Fix
Replace the substring heuristic with a call to
_looks_like_error_output()(already defined at line 272 in the same file), which:errorkey is truthy (null/false/""do not trigger)statusfield for error/failed/timeouterror:,traceback,exception:,failed:)Testing
Verified with the existing
_looks_like_error_outputfunction:{"output":"test1","exit_code":0,"error":null}→False(correct){"output":"","exit_code":127,"error":"command not found"}→True(correct)False(correct)Old heuristic: flagged the first case as
True(wrong).