fix(gateway): add NixOS system paths to systemd unit PATH#26308
Open
flooryyyy wants to merge 1 commit into
Open
fix(gateway): add NixOS system paths to systemd unit PATH#26308flooryyyy wants to merge 1 commit into
flooryyyy wants to merge 1 commit into
Conversation
61af8aa to
7987606
Compare
Contributor
Author
|
sorry, happened to miss a few silly changes. should be okay now. not sure if this was the most elegant way to do it. |
On NixOS, systemd units don't inherit the user's PATH, so system
packages (ffmpeg, curl, kill) are invisible. This breaks STT (ffmpeg
for ogg conversion) and ExecReload (/bin/kill doesn't exist).
- Prepend /run/current-system/sw/{bin,sbin} to PATH in both user and
system unit templates (only when /etc/NIXOS exists)
- Add ~/.nix-profile/{bin,sbin} to user-local path candidates
- Use /usr/bin/env kill in ExecReload instead of hardcoded /bin/kill
6a4449c to
ae8ff93
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
|
this is a low-risk change but anyone encountering this will need to ask their agent to fix it or find the issue themselves. is there any reason for not merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gateway systemd unit PATH missing /run/current-system/sw/bin on nixos.
all system packages invisible — ffmpeg, curl, kill, grep gone.
STT dead (ffmpeg needed for ogg conversion). ExecReload=/bin/kill broken.
fix: detect nixos, prepend /run/current-system/sw paths. patch kill path too.
same treatment for user-scope and system-scope unit templates.