fix(windows): make PowerShell installer parse in 5.1#26481
Closed
nekwo wants to merge 1 commit into
Closed
Conversation
03433ab to
85f3027
Compare
teknium1
added a commit
that referenced
this pull request
May 17, 2026
…tors Adds release-note attribution mappings for 10 contributors from the low-hanging-fruit salvage group 2 batch: - @shellybotmoyer (PR #26661, #25576) - @ether-btc (PR #26632) - @LifeJiggy (PR #26516) - @nekwo (PR #26481) - @flooryyyy (PR #26374) - @dgians (PR #26034, incl. zealy-tzco bot-committer alias) - @flanny7 (PR #27030) - @hermesagent26 (PR #26438) - @kriscolab (PR #26926, co-author on salvage commit)
Contributor
|
Merged via PR #27292 — your commit was cherry-picked onto current |
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…tors Adds release-note attribution mappings for 10 contributors from the low-hanging-fruit salvage group 2 batch: - @shellybotmoyer (PR NousResearch#26661, NousResearch#25576) - @ether-btc (PR NousResearch#26632) - @LifeJiggy (PR NousResearch#26516) - @nekwo (PR NousResearch#26481) - @flooryyyy (PR NousResearch#26374) - @dgians (PR NousResearch#26034, incl. zealy-tzco bot-committer alias) - @flanny7 (PR NousResearch#27030) - @hermesagent26 (PR NousResearch#26438) - @kriscolab (PR NousResearch#26926, co-author on salvage commit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[5/15/2026 1:07 PM] Tony: ## What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
scripts/install.ps1
How to Test
Checklist
Code
Documentation & Housekeeping
For New Skills
Screenshots / Logs
fill this out too
[5/15/2026 1:07 PM] Alice: 💻 terminal: "cd /x/Eternia/hermes-agent && if comm..."
💻 terminal: "python - <<'PY' import json, urllib.p..."
💻 terminal: "cd /x/Eternia/hermes-agent && test -f..."
[5/15/2026 1:12 PM] Alice: Ahhh yep, Telegram is rendering the nested code fences separately. Use this no-fence plain text block instead — copy from BEGIN to END:
BEGIN PR BODY
What does this PR do?
Fixes Windows PowerShell 5.1 parsing of scripts/install.ps1 by saving the installer with a UTF-8 BOM.
The installer contains Unicode status/branding characters such as check marks, warning symbols, arrows, and box-drawing characters. Windows PowerShell 5.1 can mis-detect UTF-8-without-BOM scripts as a legacy ANSI code page, which may cause parse/rendering failures on fresh Windows installs.
Adding the UTF-8 BOM is the smallest targeted fix: it preserves the existing installer output and makes the file unambiguously UTF-8 for Windows PowerShell 5.1, while remaining compatible with PowerShell 7.
Related Issue
#25191
Fixes #
Type of Change
Changes Made
How to Test
On Windows, parse the installer with Windows PowerShell 5.1:
$p = "X:\Eternia\hermes-agent\scripts\install.ps1"
$text = [System.IO.File]::ReadAllText($p, [System.Text.Encoding]::UTF8)
[scriptblock]::Create($text) > $null
Write-Output "parse_ok"
Confirm the output is:
parse_ok
Optionally run the installer path normally from Windows PowerShell 5.1 or PowerShell 7 and confirm the banner/status output renders without parse errors.
Checklist
Code
Documentation & Housekeeping
Screenshots / Logs
PowerShell parse validation:
Additional checks run locally:
END PR BODY