fix(run_agent): guard memory provider init against empty/whitespace string#26632
Closed
ether-btc wants to merge 1 commit into
Closed
fix(run_agent): guard memory provider init against empty/whitespace string#26632ether-btc wants to merge 1 commit into
ether-btc wants to merge 1 commit into
Conversation
teknium1
added a commit
that referenced
this pull request
May 17, 2026
…tors Adds release-note attribution mappings for 10 contributors from the low-hanging-fruit salvage group 2 batch: - @shellybotmoyer (PR #26661, #25576) - @ether-btc (PR #26632) - @LifeJiggy (PR #26516) - @nekwo (PR #26481) - @flooryyyy (PR #26374) - @dgians (PR #26034, incl. zealy-tzco bot-committer alias) - @flanny7 (PR #27030) - @hermesagent26 (PR #26438) - @kriscolab (PR #26926, co-author on salvage commit)
Contributor
|
Merged via PR #27292 — your commit was cherry-picked onto current |
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…tors Adds release-note attribution mappings for 10 contributors from the low-hanging-fruit salvage group 2 batch: - @shellybotmoyer (PR NousResearch#26661, NousResearch#25576) - @ether-btc (PR NousResearch#26632) - @LifeJiggy (PR NousResearch#26516) - @nekwo (PR NousResearch#26481) - @flooryyyy (PR NousResearch#26374) - @dgians (PR NousResearch#26034, incl. zealy-tzco bot-committer alias) - @flanny7 (PR NousResearch#27030) - @hermesagent26 (PR NousResearch#26438) - @kriscolab (PR NousResearch#26926, co-author on salvage commit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
memory.provideris configured as an empty string or whitespace-only string in config.yaml, the memory provider init is silently skipped with no warning. This makes it appear that Mnemosyne (or any provider) is active when it isn't.Fix
run_agent.pyline 1998: guardif _mem_provider_name:withand _mem_provider_name.strip()so empty and whitespace-only strings are treated the same as no provider.Testing
Trivial one-line change with no side effects — the original condition already handles
None/falsy; this extends it to cover the edge case ofprovider: ''orprovider: ' 'in config.